Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify conversion of language #399

Closed
tschmidtb51 opened this issue Jan 31, 2022 · 2 comments · Fixed by #450
Closed

Clarify conversion of language #399

tschmidtb51 opened this issue Jan 31, 2022 · 2 comments · Fixed by #450
Assignees
@sthagen @tschmidtb51
Labels
CS02 Defects of CS01 with fixes targeting CS02 editor-revision already worked on in the editor revision

Comments

@tschmidtb51
Copy link
Contributor

CVRF CSAF 1.2 had some information about the language which was hidden in the notes and applied only for specific elements. We can either:

  1. define that if such elements exist, the lang should be set to the value that was found (if multiple throw an warning that the document might contain multiple languages),
  2. define that it should be set by config
  3. define to ignore it.

I'm current in favor of option 1.

Thoughts?
@sthagen
Copy link
Contributor

sthagen commented Jan 31, 2022

Is this an issue for the CSAF or the converter repository? I would think so ...

@tschmidtb51
Copy link
Contributor Author

We should decide on the CSAF spec side what we want and bring the good news to the converter repository 😄

@tschmidtb51 tschmidtb51 added CS02 Defects of CS01 with fixes targeting CS02 and removed question labels Feb 16, 2022
tschmidtb51 added a commit to tschmidtb51/csaf that referenced this issue Feb 16, 2022
@tschmidtb51
Language conversion
c42c994 
- resolves oasis-tcs#399
- add conversion rule for language
tschmidtb51 added a commit to tschmidtb51/csaf that referenced this issue Feb 16, 2022
@tschmidtb51
Language conversion
8acd7fb 
- addresses parts of oasis-tcs#399
- adopt committee note
@tschmidtb51 tschmidtb51 mentioned this issue Feb 16, 2022
Merged
@tschmidtb51 tschmidtb51 added the editor-revision already worked on in the editor revision label Feb 16, 2022
tschmidtb51 added a commit to tschmidtb51/csaf that referenced this issue Feb 16, 2022
@tschmidtb51
Language conversion
6b1d1f5 
- addresses parts of oasis-tcs#399 and review comment in oasis-tcs#428
- clarify where to put the set of languages
@tschmidtb51 tschmidtb51 mentioned this issue Feb 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sthagen sthagen

@tschmidtb51 tschmidtb51

Labels
CS02 Defects of CS01 with fixes targeting CS02 editor-revision already worked on in the editor revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editor revision 2022 02 23 oasis-tcs/csaf
2 participants
@sthagen @tschmidtb51