Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct enforcing fingerprint #764

Closed
tschmidtb51 opened this issue Aug 7, 2024 · 0 comments · Fixed by #767
Closed

Correct enforcing fingerprint #764

tschmidtb51 opened this issue Aug 7, 2024 · 0 comments · Fixed by #767
Assignees
Labels
csaf 2.1 csaf 2.1 work editor-revision already worked on in the editor revision editorial mostly nits and consistency

Comments

@tschmidtb51
Copy link
Contributor

Currently, it is possible to add a OpenPGP key to a PMD without adding the fingerprint:

Quoting from https://docs.oasis-open.org/csaf/csaf/v2.0/provider_json_schema.json

    "public_openpgp_keys": {
      "title": "List of public OpenPGP keys",
      "description": "Contains a list of OpenPGP keys used to sign CSAF documents.",
      "type": "array",
      "items": {
        "title": "PGP keys",
        "description": "Contains all information about an OpenPGP key used to sign CSAF documents.",
        "type": "object",
        "required": [
          "url"
        ],
        "properties": {
          "fingerprint": {
            "title": "Fingerprint of the key",
            "description": "Contains the fingerprint of the OpenPGP key.",
            "type": "string",
            "minLength": 40,
            "pattern": "^[0-9a-fA-F]{40,}$"
          },
          "url": {
            "title": "URL of the key",
            "description": "Contains the URL where the key can be retrieved.",
            "$ref": "#/$defs/url_t"
          }
        }
      }
    }

The schema does not enforce the fingerprint, which is in contrast to Example 124 (see https://docs.oasis-open.org/csaf/csaf/v2.0/os/csaf-v2.0-os.html#717-requirement-7-provider-metadatajson) which is labeled as Minimal but contains a fingerprint value.

It must be an oversight, that the fingerprint is not required per schema. We should correct that.

@tschmidtb51 tschmidtb51 added editorial mostly nits and consistency csaf 2.1 csaf 2.1 work labels Aug 7, 2024
@tschmidtb51 tschmidtb51 self-assigned this Aug 7, 2024
@tschmidtb51 tschmidtb51 added the editor-revision already worked on in the editor revision label Aug 7, 2024
tschmidtb51 added a commit to tschmidtb51/csaf that referenced this issue Aug 7, 2024
- resolves oasis-tcs#764
- require `fingerprint` also via schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csaf 2.1 csaf 2.1 work editor-revision already worked on in the editor revision editorial mostly nits and consistency
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant