Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CWE artifacts #135

Merged
merged 2 commits into from
Sep 29, 2020
Merged

CWE artifacts #135

merged 2 commits into from
Sep 29, 2020

Conversation

tschmidtb51
Copy link
Contributor

@tschmidtb51
CWE artifacts
cefa098 
- resolves oasis-tcs#134, oasis-tcs#102
- rename "description" to "name"
- add fields as required
@tschmidtb51
CWE artifacts
f918d35 
- addresses documemtation related to oasis-tcs#134, oasis-tcs#102, oasis-tcs#108, oasis-tcs#109
 add generic keywords "title", "description", "examples" to the definition
@tschmidtb51 tschmidtb51 mentioned this pull request Sep 29, 2020
Merged
@sthagen sthagen self-requested a review September 29, 2020 13:33
@sthagen
Copy link
Contributor

sthagen commented Sep 29, 2020 •
edited
Loading

I will review and possibly merge into branch editor-revision-2020-09-28amending it (and sync with document/prose done in #136) this possibly late evening European time. Kudos for renaming description to name - we still have some of those colliding property names elsewhere (JSON Schema convention vs. Domain convention).

@santosomar
Copy link
Contributor

I think that this could also just be merged into the master branch.

@santosomar santosomar merged commit 4b82b37 into oasis-tcs:master Sep 29, 2020
@sthagen sthagen self-assigned this Sep 29, 2020
@sthagen sthagen added csaf 2.0 csaf 2.0 work documentation editorial mostly nits and consistency enhancement labels Sep 29, 2020
@sthagen sthagen mentioned this pull request Sep 29, 2020
Merged
@santosomar santosomar mentioned this pull request Sep 30, 2020
Closed
@santosomar santosomar linked an issue Sep 30, 2020 that may be closed by this pull request
Shall CSAF v2.0 keep the CW ID only refs or add longer descriptions? #102
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthagen sthagen Awaiting requested review from sthagen

Assignees

@sthagen sthagen

Labels
csaf 2.0 csaf 2.0 work documentation editorial mostly nits and consistency enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CWE artifacts Shall CSAF v2.0 keep the CW ID only refs or add longer descriptions?
3 participants
@tschmidtb51 @sthagen @santosomar