ROFL app details page fixes #1960
Conversation
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/rofl-all-details-page-fixes
branch
from
e31b360 to
aa371e6
Compare
csillag
force-pushed
the
csillag/rofl-all-details-page-fixes
branch
5 times, most recently
from
aef6d99 to
7c5dd81
Compare
This flags means that we don't really want to see a link, just the label, but we still want to see all the other transformations applied. (This makes it easier to keep things consistent)
csillag
force-pushed
the
csillag/rofl-all-details-page-fixes
branch
from
7c5dd81 to
3a4ab1e
Compare
These are all optional features, disabled by default.
This fixes title on mobile, when displaying a long address. (The link is used in labelOnly mode, so no actual link is displayed)
csillag
force-pushed
the
csillag/rofl-all-details-page-fixes
branch
from
3a4ab1e to
23539cb
Compare
| <MuiLink component={RouterLink} to={to}> | ||
| {name ? <HighlightedText text={name} pattern={highlightedPart} /> : address} | ||
| </MuiLink> | ||
| {labelOnly ? ( |
There was a problem hiding this comment.
Any alternative ideas for future to avoid every component adding labelOnly mode?
There was a problem hiding this comment.
Any alternative ideas for future to avoid every component adding labelOnly mode?
So, the rationale was this:
We want to do a lot of things in our links. (Show a name, or an address, or both; do highlighting based on mouse pointer and search pattern, do shortening, either fixed or adapting length, specific formatting). There are many combinations of this, some is based on configuration, some context dependent, etc.
We want to do all of these consistently both on links and labels. Duplicating the code would suck, so we keep everything together, and use the labelOnly flag to switching off linking when not needed.
An alternative would be to always have a pair of components, like <WhateverLink> and <WhateverLabel>, which would share their internal formatting and other behavior logic, except the link thing itself. Should we try that?
Tweak 1: implement page title shortening in table and mobile mode
Tweak 2: Enable highlighting matching ROFL addresses on mouse hover
(Currently this is only enabled on desktop.)
Tweak 3:
Enable tool-tip on shortened app ids: