Skip to content

Basic support for searching for ROFL apps by app name fragment #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025

Conversation

csillag
Copy link
Contributor

@csillag csillag commented May 21, 2025

This is built on top of #1960.

Suggested test URLs:

Closes #1969.

Copy link

github-actions bot commented May 21, 2025

Deployed to Cloudflare Pages

Latest commit: 47a4d404c4a3b89d1148cd81bf6a474b93eb8af5
Status:✅ Deploy successful!
Preview URL: https://75138a89.oasis-explorer.pages.dev
Alias: https://pr-1973.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/search-for-rofl-app-by-name branch 2 times, most recently from 8e8888c to ff352f9 Compare May 21, 2025 15:29
@csillag csillag marked this pull request as ready for review May 21, 2025 15:32
@csillag csillag self-assigned this May 21, 2025
@csillag
Copy link
Contributor Author

csillag commented May 22, 2025

This code has now been updated to work with the latest nexus version (v0.6.14) which is not yet deployed on the OPF server instances. When running with older Nexus versions, it will provide false matches among the results. If someone wants to test the code against the old nexus version, just drop the last commit which removes the client-side workaround.

(But this workaround won't be needed as soon as latest nexus is deployed, in a few hours.)

@csillag
Copy link
Contributor Author

csillag commented May 22, 2025

This code has now been updated to work with the latest nexus version (v0.6.14) which is not yet deployed on the OPF server instances. When running with older Nexus versions, it will provide false matches among the results. If someone wants to test the code against the old nexus version, just drop the last commit which removes the client-side workaround.

(But this workaround won't be needed as soon as latest nexus is deployed, in a few hours.)

Nexus deployed, so this is no longer relevant.

@csillag csillag force-pushed the csillag/search-for-rofl-app-by-name branch 2 times, most recently from 4217dfe to ad1d017 Compare May 24, 2025 10:06
@csillag
Copy link
Contributor Author

csillag commented May 24, 2025

This has been rebased on latest master, and is now ready to be reviewed / merged

@csillag csillag force-pushed the csillag/search-for-rofl-app-by-name branch from ad1d017 to f15b5e2 Compare May 28, 2025 09:32
@csillag csillag force-pushed the csillag/search-for-rofl-app-by-name branch from f15b5e2 to 47a4d40 Compare May 28, 2025 09:46
@csillag csillag merged commit 19ba9d2 into master May 28, 2025
9 checks passed
@csillag csillag deleted the csillag/search-for-rofl-app-by-name branch May 28, 2025 09:48
@csillag csillag restored the csillag/search-for-rofl-app-by-name branch May 29, 2025 11:30
@csillag csillag deleted the csillag/search-for-rofl-app-by-name branch May 29, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Allow searching for ROFL apps by name fragment
2 participants