Skip to content

Add Store.attach. #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2022
Merged

Add Store.attach. #376

merged 2 commits into from
Feb 22, 2022

Conversation

greenrobot-team
Copy link
Member

@greenrobot-team greenrobot-team commented Jan 31, 2022 •
edited
Loading

@greenrobot-team greenrobot-team force-pushed the store-attach branch 3 times, most recently from e626c2c to 67e3b32 Compare February 1, 2022 10:35
greenrobot
greenrobot previously requested changes Feb 1, 2022
View reviewed changes
Copy link
Member

@greenrobot greenrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; please merge after changes

@greenrobot-team
Copy link
Member Author

greenrobot-team commented Feb 7, 2022 •
edited
Loading

From stand-up: change to not allow using Store.attach with store already opened in same isolate (re-add dbDir check). This is to prevent incorrect usage (e.g. opening transactions in both stores at the same time is not possible).

@greenrobot-team greenrobot-team force-pushed the store-attach branch 3 times, most recently from f17f20c to cb7d236 Compare February 7, 2022 10:28
@greenrobot greenrobot mentioned this pull request Feb 9, 2022
Closed
@greenrobot-team greenrobot-team force-pushed the c-lib-0.15.0 branch 2 times, most recently from 80a365c to bfb9d30 Compare February 21, 2022 10:47
@greenrobot-team greenrobot-team changed the base branch from c-lib-0.15.0 to main February 21, 2022 14:47
@greenrobot-team greenrobot-team marked this pull request as ready for review February 21, 2022 14:51
@greenrobot-team greenrobot-team mentioned this pull request Feb 21, 2022
Merged
1 task
@greenrobot-team greenrobot-team added this to the 1.4 milestone Feb 21, 2022
@greenrobot-team greenrobot-team merged commit 183aade into main Feb 22, 2022
@greenrobot-team greenrobot-team deleted the store-attach branch February 22, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greenrobot greenrobot greenrobot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@greenrobot-team @greenrobot