Skip to content

Commit 0b3a888

Browse files
GitLab: update merge request template
1 parent b5ea1ca commit 0b3a888

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed
Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,27 @@
11
## What does this merge request do?
22

3-
<!-- TODO Link associated issue from title, like: <title> objectbox-java#NUMBER -->
3+
TODO Link associated issue from title, like: `<title> objectbox-java#NUMBER`
44

5-
<!-- TODO Briefly list what this merge request is about -->
5+
TODO Briefly list what this merge request is about
66

77
## Author's checklist
88

99
- [ ] This merge request fully addresses the requirements of the associated task
1010
- [ ] I did a self-review of the changes and did not spot any issues, among others:
11-
- I added unit tests for new or changed behavior; existing and new tests pass
12-
- My code conforms to our coding standards and guidelines
13-
- My changes are prepared (focused commits, good messages) so reviewing them is easy for the reviewer
11+
- I added unit tests for new or changed behavior; existing and new tests pass
12+
- My code conforms to our coding standards and guidelines
13+
- My changes are prepared (focused commits, good messages) so reviewing them is easy for the reviewer
1414
- [ ] I amended the objectbox-java changelog if this affects users in any way
1515
- [ ] I assigned a reviewer to request review
1616

1717
## Reviewer's checklist
1818

19-
- [ ] I reviewed all changes line-by-line and addressed relevant issues
19+
- [ ] I reviewed all changes line-by-line and addressed relevant issues. However:
20+
- for quickly resolved issues, I considered creating a fixup commit and discussing that, and
21+
- instead of many or long comments, I considered a meeting with or a draft commit for the author.
2022
- [ ] The requirements of the associated task are fully met
2123
- [ ] I can confirm that:
22-
- CI passes
23-
- If applicable, coverage percentages do not decrease
24-
- New code conforms to standards and guidelines
25-
- If applicable, additional checks were done for special code changes (e.g. core performance, binary size, OSS licenses)
24+
- CI passes
25+
- If applicable, coverage percentages do not decrease
26+
- New code conforms to standards and guidelines
27+
- If applicable, additional checks were done for special code changes (e.g. core performance, binary size, OSS licenses)

0 commit comments

Comments
 (0)