Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-aux: Use Mbed TLS for libdatachannel #10024

Conversation

Sean-Der
Copy link
Contributor

Description

Switch to Mbed TLS for libdatachannel in flatpak

Motivation and Context

Resolves #9846 WHIP now works in flatpak

This also matches how libdatachannel is used on other platforms (mac OS)

How Has This Been Tested?

Locally when I use WHIP it works

Types of changes

  • Bug fix (non-breaking change which fixes an issue) -->

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Sean-Der
Copy link
Contributor Author

@pkviet @tt2468

@WizardCM WizardCM added the Bug Fix Non-breaking change which fixes an issue label Dec 20, 2023
@tytan652
Copy link
Collaborator

tytan652 commented Dec 20, 2023

Resolves #9846 WHIP now works in flatpak

This also matches how libdatachannel is used on other platforms (mac OS)

Missing explanation on why the OpenSSL backend on Flatpak causes issues, matching (and it just works) is not good as only motivation.

@Sean-Der
Copy link
Contributor Author

@tytan652 Here is the PR upstream paullouisageneau/libdatachannel#1075

The version of OpenSSL currently used doesn't return a curve for P-256, only prime256v1

I will land the change upstream and then update obs-deps

@Sean-Der
Copy link
Contributor Author

Sean-Der commented Jan 1, 2024

Closing. Instead opened a PR upstream against libdatachannel to use different curve alias

@Sean-Der Sean-Der deleted the flatpak-libdatachannel-use-mbedtls branch January 1, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash - WHIP runtime error: unable to generate ECDSA P-256 key pair
3 participants