OBS Crashes with this WHIP #9800
Comments
|
Please provide a crash log.
|
|
Here it goes: It might be related to something triggering it, as sometimes it works, sometimes not, depending on when i restart the media server too apparently. Whenever this is triggered, OBS just closes on its own crashing |
|
Thank you. Relevant part of the crash log: cc @Sean-Der |
|
I think I tracked the bug down to the a=fingerprint line. If the sdp has
It works, but if it has
It crashes |
|
It crashes too with
|
|
Yet another one: It seems the problem is that there are missing fingerprint algorithms? |
|
Thank you @MarianoFacundoArch SHA-256 is what the majority of servers/clients use now, not surprised about the code path! I will fix upstream now! |
|
Nice Sean , let me know if i can help you somehow or to try after it's been taken care of. below is a list of possible fingerprints with the algorithms that you might want to use as a reference to see all the options! |
|
@Sean-Der Is this possibly the same issue described in our forum beta/RC thread? |
|
@RytoEX Unrelated unfortunately! That issue is for local certificate generation at session start. WHIP worked in flatpak at one point. Let me bisect locally to find when it broke. |
|
Sorry, misslick. |
|
@Sean-Der, sorry for pinging. Have you managed to find the reason why it no longer works? |
|
Please ping me anytime! I am always happy to help :) I haven't had a chance unfortunately. I can show you how to do it (if you are interested) |
|
Could you try out previous betas? See if we can start to establish a window of when it worked/broke |
|
in linux crashes all obs versions i tried 3.0.0, rc2, beta3 , against broadcast box and srs servers |
|
If it helps, non-flatpak version distributed in Fedora repos, works as expected. It seems to be a problem exclusive to the Flatpak version. |
|
Hi @uxex @ArmorDarks I have fixed the Flatpak issue! Upstream PR is here You could also use the flatpak builds where we switch to MbedTLS here |
|
I have a fix for libdatachannel not support all hash functions here @MarianoFacundoArch Would it be helpful for me to generate builds? I hope to have PR against obs-deps in next few days :) |
|
@MarianoFacundoArch I am also using MediaSoup, did you find any work around to prevent the OBS crash? i.e. forcing sha-256? |
|
@sreplans The only solution I know of is to use my patch. if you are unable to build yourself I am happy to generate a build! |
|
@Sean-Der Thank you!!! Is it possible to get a Window build and an OS X build? or either at this point! |
|
I can get you both! I will have updated builds in 24 hours :) |
|
Awesome 😎 thank you
…On Fri, Dec 29, 2023 at 7:04 PM Sean DuBois ***@***.***> wrote:
I can get you both! I will have updated builds in 24 hours :)
—
Reply to this email directly, view it on GitHub
<#9800 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACM77EIOUEBADXX5STAAFXTYL4A4TAVCNFSM6AAAAAA65TRV62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZSGI2TCOJYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Fixed it! Should have builds soon |
This comment was marked as outdated.
This comment was marked as outdated.
|
I have builds! @sreplans Go to https://github.com/Sean-Der/obs-studio/actions/runs/7374742667?pr=6 Here are direct links |
|
Thank you sooo much!!!! I'll check them out.
…On Mon, Jan 1, 2024 at 9:13 AM Sean DuBois ***@***.***> wrote:
I have builds!
@sreplans <https://github.com/sreplans> Go to
https://github.com/Sean-Der/obs-studio/actions/runs/7374742667?pr=6
Here are direct links
- mac arm64 -
https://github.com/Sean-Der/obs-studio/actions/runs/7374742667/artifacts/1141537317
- mac x64 -
https://github.com/Sean-Der/obs-studio/actions/runs/7374742667/artifacts/1141537318
- windows -
https://github.com/Sean-Der/obs-studio/actions/runs/7374742667/artifacts/1141537320
—
Reply to this email directly, view it on GitHub
<#9800 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACM77EM7YHIJKK7EUAE5HDTYMLAAXAVCNFSM6AAAAAA65TRV62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZTGM2DINRZGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@Sean-Der macOS Crash ReportTranslated Report (Full Report Below)Process: OBS [58914] Date/Time: 2024-01-02 11:13:43.1400 -0500 Sleep/Wake UUID: 14113896-E55B-47D2-9D3E-D4DFF6F5221F Time Awake Since Boot: 330000 seconds System Integrity Protection: enabled Crashed Thread: 23 Exception Type: EXC_CRASH (SIGABRT) Termination Reason: Namespace SIGNAL, Code 6 Abort trap: 6 Application Specific Information: Thread 0:: Dispatch queue: com.apple.main-thread Thread 1: Thread 2: Thread 3: Thread 4: Thread 5:: com.apple.CFSocket.private Thread 6: Thread 7:: libobs: hotkey thread Thread 8:: tiny_tubular_task_thread Thread 9:: Thread (pooled) Thread 10:: Thread (pooled) Thread 11:: audio-io: audio thread Thread 12:: video-io: video thread Thread 13:: libobs: graphics thread Thread 14: Thread 15:: caulk::deferred_logger Thread 16:: caulk.messenger.shared:high Thread 17:: caulk.messenger.shared:17 Thread 18:: com.apple.audio.IOThread.client Thread 19:: MacUpdateThread Thread 20:: WhatsNewInfoThread Thread 21:: com.apple.coremedia.sharedRootQueue.47 Thread 22:: com.apple.coremedia.sharedRootQueue.47 Thread 23 Crashed: Thread 24:: RTC worker Thread 25:: RTC worker Thread 26:: RTC worker Thread 27:: RTC worker Thread 28:: RTC worker Thread 29:: RTC worker Thread 30:: RTC worker Thread 31:: RTC worker Thread 32:: RTC worker Thread 33:: RTC worker Thread 34:: SCTP iterator Thread 35:: SCTP timer Thread 36:: juice poll Thread 23 crashed with ARM Thread State (64-bit): Binary Images: External Modification Summary: VM Region Summary: REGION TYPE SIZE COUNT (non-coalesced) Full Report{"app_name":"OBS","timestamp":"2024-01-02 11:13:43.00 -0500","app_version":"29.1.0","slice_uuid":"31a91b0f-09f9-3148-b520-e1bdd588b632","build_version":"7374742667","platform":1,"bundleID":"com.obsproject.obs-studio","share_with_app_devs":0,"is_first_party":0,"bug_type":"309","os_version":"macOS 14.2 (23C64)","roots_installed":0,"name":"OBS","incident_id":"1061E053-C8F4-4CB0-8D2A-1C64B0DCAD08"} } ], ] Model: MacBookPro18,2, BootROM 10151.61.4, proc 10:8:2 processors, 32 GB, SMC |
Thank you for providing the crash report - in the future please upload it as a text file or use GitHub's Markdown formatting to make it expendable and use fixed-width formatting (this was fixed via an edit on your post already). Posting the full report as a GitHub comment makes it very hard to read and parse for maintainers and also makes it harder for other people to engage with the comment thread (because they have to scroll for pages before reaching any other comments). |
|
@sreplans is this a public server? Can I test against it possibly? Does look like it is throwing on a certificate issue still. I tested with mediasoup locally, maybe something else? |
|
I am |
|
@Sean-Der thanks. I sent you a public server link to your email. I don't use discord.... let me know if you got it , and thanks! |
|
Got your email. Good news is that the builds work for me locally! |
|
Confirmed with @sreplans via email. The WHIP endpoint is responding with No matter what the root issue is unrelated! My PR fixes the issue of supporting non-sha256 fingerprints. |
|
Awesome! thank you. I'll see if I can fix the endpoint! |
|
I got a few emails/DMs asking for flatpak builds. I put it on my personal server for now. |
|
For Windows/Mac builds see #9800 (comment) |
|
Hello @Sean-Der , I have tested your custom build of OBS and tested WHIP with LiveKit Ingress, and I am able to have an streaming working in a room for some seconds. But eventually I end up with this log error: Other types of NALU appears. I do not understand the low level details about the RTP protocol for x264, but I suppose by these errors that OBS is sending some RTP packet or information that Transcoding is disabled, so I suppose the media is being sent directly to the room as a new Participant into the room. I did not test with your Broadcast Box server, but I though it would be good to notify my results after testing it, just in case is something related with OBS. I've tested with:
|
@Sean-Der thank you for looking into the issue with the I'm confused about the requirement for it to be According to the latest WHIP spec:
Based on my understanding, Additionally, it seems unsound that OBS crashes without providing any useful explanation in this case, and I guess it shouldn't crash at all. Should I create a separate issue for this? |
|
100% agree on better error handling. When we get a new version of libdatachannel + obs-deps I will add a |
Operating System Info
macOS 14
Other OS
No response
OBS Studio Version
30.0.0-rc2
OBS Studio Version (Other)
No response
OBS Studio Log URL
https://obsproject.com/logs/zpTpVWH7AhTyBaMB
OBS Studio Crash Log URL
No response
Expected Behavior
it should not crash and start broadcasting
Current Behavior
It crashes, closes
Steps to Reproduce
Configure OBS to use a WHIP server.
I provide a sample WHIP answer that makes it crash. What is curious is that it closes no matter what, even if I put an invalid ip (that would not be able to connect to, so should not crash, and give connection error instead).
Sometimes it worked, but it's randomly, most of the time just... closes itself.
Anything else we should know?
No response
The text was updated successfully, but these errors were encountered: