-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Check VC++ Runtime version on startup #10809
Conversation
6da7d33
to
3d0cdf4
Compare
3d0cdf4
to
5577243
Compare
5577243
to
ba02d41
Compare
Perhaps the wording could be changed to "You will now be directed to the download page." with OK / Cancel buttons. Currently it's unclear that pressing "No" will exit OBS. |
ba02d41
to
abc0a7b
Compare
I updated the wording (not the screenshot though). I also wasn't super happy with it, but I didn't have any better ideas. Perhaps @Warchamp7 has a suggestion as well. Either way I'd like to have this for beta2 (alongside the updater/installer changes) so we can mitigate the VC runtime mess as much as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe there's a better way to handle this, but if we figure that out, we can make further changes later. Let's mitigate this as much as we can.
I my project I find out the std::mutex is incompatible with old msvcp140.dll, I tested with the simplest mutext code. Adding |
We considered this and decided against it. |
Description
Adds a check on startup that ensures a compatible Visual C++ runtime is being used.
The user is given the option to automatically open our existing VC runtime download page (https://obsproject.com/visual-studio-2019-runtimes),
Motivation and Context
Due to backwards-incompatible changes in MSVC 14.40 OBS crashes on startup for some users that do not have up to date runtimes installed. See #10799.
We should also adjust the updater and installer to check for these older versions, but that will be a larger undertaking and also does not cover the use case of portable ZIPs (unlike this PR).
How Has This Been Tested?
Tested on Windows VM with outdated vc runtime:
Types of changes
Checklist: