Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updater: Check and update VC runtime version #10817

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

derrod
Copy link
Member

@derrod derrod commented Jun 9, 2024

Description

Updates the updater to check the VC runtime version and install the latest version if appropiate.

Detailed changes:

  • Minor version of msvcp140 is checked to be >= 40
  • VC installer is downloaded from MS permalink instead of OBS mirror
  • VC installer digital signature is verified before execution
  • Updater is again compiled with /MT, otherwise it would also crash due to the same problem that OBS itself breaks (std::mutex changes)

Motivation and Context

Companion to #10809.

How Has This Been Tested?

Tested on VM and Windows Sandbox.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@derrod derrod added Bug Fix Non-breaking change which fixes an issue Windows Affects Windows labels Jun 9, 2024
@derrod derrod requested a review from notr1ch June 9, 2024 21:36
UI/win-update/updater/cmake/legacy.cmake Outdated Show resolved Hide resolved
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay at a glance. Would appreciate a second review.

@RytoEX RytoEX added this to the OBS Studio 30.2 milestone Jun 10, 2024
@RytoEX RytoEX self-assigned this Jun 10, 2024
@RytoEX RytoEX merged commit 0cfae86 into obsproject:master Jun 11, 2024
15 checks passed
@derrod derrod deleted the updater-check-vcrun branch June 11, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Windows Affects Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants