Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Work around Qt dock restore crash #8135

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

derrod
Copy link
Member

@derrod derrod commented Jan 24, 2023

Description

This is a workaround for #7348. It doesn't fix it, but at least gets OBS up and running again by not attempting to restore the integration docks when OBS is in a state that would cause the crash (not visible but maximised).

Motivation and Context

Want to keep users at least up and running, even with the minor inconvenience of having their docks fucked up.

How Has This Been Tested?

Tested in debugger to ensure no crashes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@derrod derrod added Bug Fix Non-breaking change which fixes an issue Seeking Testers Build artifacts on CI labels Jan 24, 2023
@jp9000 jp9000 merged commit 3dcf68f into obsproject:master Jan 25, 2023
@derrod derrod deleted the qt-crash-workaround branch January 25, 2023 03:02
@RytoEX RytoEX mentioned this pull request Jan 26, 2023
6 tasks
@RytoEX RytoEX added this to the OBS Studio 29.0 milestone Jan 26, 2023
@tytan652 tytan652 mentioned this pull request Jul 8, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Seeking Testers Build artifacts on CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants