Skip to content

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Aug 12, 2025

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 0% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 6.76%. Comparing base (457d2cd) to head (137ae89).

Files with missing lines Patch % Lines
src/hooks/auth.tsx 0.00% 59 Missing ⚠️
src/utils/auth.ts 0.00% 9 Missing ⚠️
src/utils/general.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #87      +/-   ##
========================================
- Coverage   7.16%   6.76%   -0.40%     
========================================
  Files        108     108              
  Lines       1256    1330      +74     
  Branches     233     244      +11     
========================================
  Hits          90      90              
- Misses      1163    1237      +74     
  Partials       3       3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)


src/hooks/auth.tsx line 263 at r2 (raw file):

  useEffect(() => {
    if (sessionMetadata) onRetrieveSession(sessionMetadata)
    else if (searchParams.code && searchParams.state) {

move to separate if check

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@SKairinos SKairinos merged commit 6332e5c into main Aug 15, 2025
16 of 17 checks passed
@SKairinos SKairinos deleted the sso-backend-34 branch August 15, 2025 07:57
@cfl-bot
Copy link
Collaborator

cfl-bot commented Aug 15, 2025

🎉 This PR is included in version 2.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

implement OAuth 2.0 for teacher sign-in

4 participants