Skip to content

Conversation

@tmattio
Copy link
Collaborator

@tmattio tmattio commented Jun 17, 2023

@pitag-ha what would you like to see highlighted in the announcement apart from the compat with 5.1?

Copy link
Member

@pitag-ha pitag-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the following would be too long? Btw, I haven't put much thought into the wording, feel free to rephrase it.


We're pleased to announce the release of Ppxlib 0.30.0.

This release comes with support for OCaml 5.1 and brings several improvements and bug fixes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This release comes with support for OCaml 5.1 and brings several improvements and bug fixes.
This release comes with support for OCaml 5.1 and brings several improvements and bug fixes.
On the side of writing PPXs, the user experience of `Ast_pattern` and `metaquot` have been
improved by adding more utility functions to the former and improving the error reporting of
the latter. On the side of using PPXs, the experience of compatibility with OCaml `trunk`
has been improved: the Driver gets biased into recognizing the accurate Parsetree version on
non-unique Parsetree magic numbers, allowing for general compatibility with both `trunk` and
stable OCaml versions at the same time. Furthermore, the release makes Ppxlib compatible
with ReScript by adding "ns" and "res" as reserved namespaces.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's perfect, I'll use this and rephrase it if needed, thanks!

Co-authored-by: Sonja Heinze <sonjaleaheinze@gmail.com>
@tmattio tmattio force-pushed the announce-ppxlib-0-30-0 branch from 1818fe7 to ea798ec Compare June 20, 2023 09:30
@tmattio
Copy link
Collaborator Author

tmattio commented Jun 20, 2023

Ready to go when Ppxlib lands on opam-repository (ocaml/opam-repository#23965).

@christinerose don't hesitate to have a look as well if you want

Copy link
Contributor

@christinerose christinerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked a few questions about formatting certain words for the purpose of clarity.

@pitag-ha
Copy link
Member

Thanks @christinerose! With your review, I've noticed how sloppy we are with formatting/readability of changelog entries. I'll try to pay more attention to it.

@christinerose
Copy link
Contributor

christinerose commented Jun 20, 2023

Thanks @christinerose! With your review, I've noticed how sloppy we are with formatting/readability of changelog entries. I'll try to pay more attention to it.

No worries! It's my job to ensure things are consistent and clear, so I'm more than happy to do it!! In fact, being the English geek I am, I really enjoy it. 😊

Co-authored-by: Christine Rose <christinerose@users.noreply.github.com>
Co-authored-by: Sonja Heinze <sonjaleaheinze@gmail.com>
@tmattio tmattio merged commit 3a92683 into main Jun 22, 2023
@tmattio tmattio deleted the announce-ppxlib-0-30-0 branch June 22, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants