html backend: fix linking to mld pages #528
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drup
reviewed
Oct 29, 2020
| @ target_from_common_ancestor | ||
| in | ||
| let page = String.concat "/" relative_target in | ||
| let page = if kind="page" then page ^ ".html" else page in |
There was a problem hiding this comment.
That's not the right place, you should fix Path.for_linking above. Looking at it, the implementation should probably merge code with as_filename as much as possible...
|
Oups, I'm surprised I didn't realized it in the tests .... The fix is not in the right place though. |
|
I have a patch incoming that contains a fix for this, so I'm closing this PR. Thanks though! |
jonludlam
added a commit
to jonludlam/odoc
that referenced
this pull request
Nov 17, 2020
This should additionally fix the issue mentioned in PR ocaml#528 Signed-off-by: Jon Ludlam <jon@recoil.org>
jonludlam
added a commit
to jonludlam/odoc
that referenced
this pull request
Nov 17, 2020
This should additionally fix the issue mentioned in PR ocaml#528 Signed-off-by: Jon Ludlam <jon@recoil.org>
jonludlam
added a commit
to jonludlam/odoc
that referenced
this pull request
Dec 8, 2020
This should additionally fix the issue mentioned in PR ocaml#528 Signed-off-by: Jon Ludlam <jon@recoil.org>
jonludlam
added a commit
to jonludlam/odoc
that referenced
this pull request
Dec 16, 2020
This should additionally fix the issue mentioned in PR ocaml#528 Signed-off-by: Jon Ludlam <jon@recoil.org>
jonludlam
added a commit
to jonludlam/odoc
that referenced
this pull request
Jan 5, 2021
This should additionally fix the issue mentioned in PR ocaml#528 Signed-off-by: Jon Ludlam <jon@recoil.org>
jonludlam
added a commit
that referenced
this pull request
Jan 5, 2021
This should additionally fix the issue mentioned in PR #528 Signed-off-by: Jon Ludlam <jon@recoil.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the link generated for
{!page:mld}in the html backend refers tomldrather thanmld.html.This PR fixes this issue.