Skip to content

html backend: fix linking to mld pages #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

html backend: fix linking to mld pages #528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/html/link.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ let href ~resolve { Url.Anchor. page; anchor; kind } =
@ target_from_common_ancestor
in
let page = String.concat "/" relative_target in
let page = if kind="page" then page ^ ".html" else page in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not the right place, you should fix Path.for_linking above. Looking at it, the implementation should probably merge code with as_filename as much as possible...

begin match anchor with
| "" -> page
| anchor -> page ^ "#" ^ anchor
Expand Down