Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow font size as parameter to AddFontDefault #1076

Closed
drewish opened this issue Mar 22, 2017 · 3 comments
Closed

Allow font size as parameter to AddFontDefault #1076

drewish opened this issue Mar 22, 2017 · 3 comments

Comments

@drewish
Copy link

drewish commented Mar 22, 2017

I'd like to use the default font but multiply the size so it works with retina/high resolution screens. I'm curious what people think about adding that as a parameter. AddFontDefault already takes an optional ImFontConfig param but I'm not seeing it used anywhere. I don't know if it would make sense to try pass the font size in via the config (which looks like it would be overwritten during the call to AddFontFromMemoryCompressedBase85TTF) or just add a new parameter with a default value of 13 to preserve the current behavior.

I'm happy to open up a PR once there's an idea of the best path forward.

@colesnicov
Copy link

Have you tried looking for?

#407
#658

@ocornut
Copy link
Owner

ocornut commented Mar 22, 2017

@drewish please use the workaround linked above. If you are trying to solve Hi-DPI support then it should eventually be handled more naturally by the library and I'd prefer not encouraging people to rescale the default font (which isn't really meant to be rescaled).

@drewish
Copy link
Author

drewish commented Mar 22, 2017

Ah apologies I'd definitely missed those. That makes sense to me.

@drewish drewish closed this as completed Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants