Allow base64 content for create/update file #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftkey
reviewed
Oct 7, 2016
| @@ -106,7 +106,7 @@ public class CreateFileRequest : ContentRequest | |||
| /// Creates an instance of a <see cref="CreateFileRequest" />. | |||
| /// </summary> | |||
| /// <param name="message">The message.</param> | |||
| /// <param name="content">The content.</param> | |||
| /// <param name="content">The content encoded in base64.</param> | |||
There was a problem hiding this comment.
@ryangribble @haacked how do we feel about this breaking change? Should we instead introduce overloads?
There was a problem hiding this comment.
Yeah, that's a very subtle breaking change. Probably best to use an overload.
Someday I'd like to write a Base64Content type. 😄 rather than using strings for everything.
|
+1 on not making a breaking change The overload approach you've gone with seems ok to me 👍 |
|
Sorry for the delay @laedit This LGTM and the integration tests are 👌 plus the revisions make it a non breaking change 😀 Thanks for the contribution! |
|
@ryangribble No problem, thanks for the merge 😄 |
nickfloyd
added
Type: Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1143.
Since 1.0 has not been reached yet, I made the fix minimal and as I think the method should have been originally, but there is a breaking change.
If you want to mitigate the breaking change I propose three ways:
Contentcontains base64 content. Breaking change onContent.Get(). Could add corresponding ctors with bool if convert to base64.Base64CreateFileRequestwith a virtualContentproperty wich contains base64 content.CreateFileRequestoverrides it and provides decoded content.SerializeIgnoreandSerializeNameattributes, add first onContentand second on new propertyBase64Content. When set,Contentconvert value to base64 and setBase64Content.