Json serialization for Unicode #972
Conversation
Fixes for json serialization issue when unicode is present.
Tests for Unicode character serialization
Compared if the serialized data has what was expected. Not just deserialized data.
|
Sweet. :) |
|
I'm hesitant to take this because If not, could you submit a PR upstream to https://github.com/facebook-csharp-sdk/simple-json? I worry that the next time we upgrade, we'll break this. At least the unit test will catch it though. 😄 |
|
@haacked I looked for that first before making the change. https://github.com/facebook-csharp-sdk/simple-json hasn't been updated in the last 20 months. There is already a PR with this fix for the main repo which is still pending from April. That's the reason for making a change in this repo. I understand your concerns. What do you want to do? |
|
Ping @prabirshrestha and ask what he's been up to? 😉 |
|
Ok, as long as the PR is upstream, I'll take this one. |
This will fix the Unicode Json serialization bug #967.
When I was looking at the code I realized there was already a fix with a PR facebook-csharp-sdk/simple-json#66 .Reused the same code for this fix.