Complete PullRequest Merged field changes #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ys false any more. octokit#867
Add Merged boolean property, returning MergedAt.HasValue
|
As the webhooks weren't configured, I pulled this down and ran the relevant tests 👍 🎉 Thanks for closing this out @ryangribble! |
shiftkey
added a commit
that referenced
this pull request
Dec 13, 2015
Complete PullRequest Merged field changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #970 (which replaced #936)
As well as the original changes that removed the Merged property, Ive also removed MergeCommitSha as mentioned by @haacked in #936
Ive actually added the
bool Mergedproperty back, with only a getter that returnsMergedAt.HasValueHappy with this? Otherwise I could remove this property entirely and all consumers would have to do their own check for
MergedAt.HasValue