Skip to content

Conversation

@wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented Jun 20, 2023

See the following issue in @octokit/graphql

Resolves #ISSUE_NUMBER


Behavior

Before the change?

  • This package had a dependency on ^8.0.0 and 8.0.0 contains a bug for graphql previews
  • Users of the web bundle would get this bad version

After the change?

  • Upgrades the version required to be at least the fixed version
  • Users should get the fixed version

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Dependencies/code cleanup: Type: Maintenance

For some reason, clients are not getting the updated version of `@octokit/endpoint` via other packages that require `@octokit/request`

See octokit/auth-app.js#499
@wolfy1339 wolfy1339 added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR Priority: High labels Jun 20, 2023
@gr2m gr2m merged commit ed784b0 into main Jun 20, 2023
@gr2m gr2m deleted the upgrade-octokit-endpoint branch June 20, 2023 20:58
@github-actions
Copy link

🎉 This PR is included in version 7.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants