Skip to content

replace ./src/http-error with @octokit/request-error #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2019
Merged

replace ./src/http-error with @octokit/request-error #58

merged 1 commit into from
May 17, 2019

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented May 16, 2019 •
edited by wolfy1339
Loading

fixes #57

wolfy1339
wolfy1339 approved these changes May 17, 2019
View reviewed changes
Copy link
Member

@wolfy1339 wolfy1339 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@gr2m gr2m merged commit 68bdbc4 into master May 17, 2019
@gr2m gr2m deleted the octokit-error branch May 17, 2019 03:21
@wolfy1339 wolfy1339 mentioned this pull request May 17, 2019
Closed
@octokitbot
Copy link
Contributor

🎉 This PR is included in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfy1339 wolfy1339 wolfy1339 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extract src/http-error.ts into its own plugin

3 participants

@gr2m @octokitbot @wolfy1339