Master wowl fix dam #1016
Closed
Master wowl fix dam #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polymorphe57
force-pushed
the
master-wowl-fix-dam
branch
from
d5e37b7 to
9eb14a7
Compare
Polymorphe57
commented
Aug 12, 2021
Polymorphe57
force-pushed
the
master-wowl-fix-dam
branch
from
9eb14a7 to
857437e
Compare
Before this commit, a loss of state was observed when "reloading" a view by clicking quickly several times in the view switcher. This was due to the fact that each click did modify the function "getLocalState" of the current controller (in the sense used by the action service) despite the fact that the corresponding view could not be mounted and thus be able to communicate its state (the exportLocalState callback is only registered when the view is mounted via a useEffect). Here we correctly wait the view to be mounted to modify getLocalState. We do the same for getGlobalState for consistency even if a similar problem was not observable in that case (the way in which global states passed to views are computed is different).
Polymorphe57
force-pushed
the
master-wowl-fix-dam
branch
from
857437e to
d08f715
Compare
|
robodoo r+ |
|
Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/9397435) |
|
robodoo retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.