fix warnings

nmarotte · nmarotte · commit 806b219ba336 · 2023-10-05T08:31:50.000+02:00
diff --git a/content/administration/upgrade.rst b/content/administration/upgrade.rst
@@ -19,7 +19,7 @@ Here are a few examples of supported upgrades:
 Upgrading to an :doc:`unsupported version </administration/maintain/supported_versions>` is not possible.
 
 .. note::
-    An upgrade does not cover : 
+    An upgrade does not cover :
 
    * Downgrading to a previous version of Odoo (i.e., Odoo 15 to Odoo 12)
    * Changing :ref:`editions <install/editions>` (i.e., Community to Enterprise edition)
@@ -29,7 +29,7 @@ Upgrading to an :doc:`unsupported version </administration/maintain/supported_ve
 .. important::
     If your database contain a custom module, :doc:`its source code must be upgraded </developer/reference/upgrade>` to the new version of Odoo before going through with the upgrade.
 
-In case of issues with the upgrade, you can contact the `support team <https://www.odoo.com/help>` for assistance.
+In case of issues with the upgrade, you can contact the `support team <https://www.odoo.com/help>`_ for assistance.
 
 
 .. _upgrade/request-test-database:
@@ -46,7 +46,7 @@ In all cases, your data follows the same process as described in the following d
     :alt: Schema of the upgrade process : Export the database to a file, upload to the upgrade server, standard upgrade scripts, download the upgraded database, import the file into a database, (Optional : Custom upgrade scripts)
     :align: center
 
-Where the standard upgrade scripts consists of a sequence of :ref:`reference/upgrade/migration-scripts`, each responsible for upgrading a specific part of a module's data. 
+Where the standard upgrade scripts consists of a sequence of :ref:`reference/upgrade/migration-scripts`, each responsible for upgrading a specific part of a module's data.
 
 .. note::
     You can always request a new upgraded test database in case you want to test the upgrade again or if you want to test the upgrade to a different version of Odoo.
@@ -57,16 +57,15 @@ Where the standard upgrade scripts consists of a sequence of :ref:`reference/upg
 
         .. _upgrade/request-test-database/odoo-online:
 
-        Odoo databases can be manually upgraded directly from the main Odoo website. To upgrade an Odoo database, navigate to the `database manager <https://www.odoo.com/my/databases>` page and sign in.
+        Odoo databases can be manually upgraded directly from the main Odoo website. To upgrade an Odoo database, navigate to the `database manager page <https://www.odoo.com/my/databases>`_ page and sign in.
 
         The database manager page displays all of the Odoo databases associated with the user's account. Any databases that are not already on the most recent version of Odoo display an **arrow in a circle** icon next to the database name, indicating that the database can be upgraded.
 
         .. image:: /administration/upgrade/odoo_online/databases-page.png
             :align: center
             :alt: The database manager page with an upgrade button next to the name of a database.
 
-        
-        Clicking on the **arrow in a circle** icon to display the following pop-up 
+        Clicking on the **arrow in a circle** icon to display the following pop-up
 
         .. image:: /administration/upgrade/odoo_online/upgrade-pop-up.png
             :align: center
@@ -94,7 +93,7 @@ Where the standard upgrade scripts consists of a sequence of :ref:`reference/upg
             :align: center
             :alt: Odoo.sh project and tabs
 
-        The **latest production daily automatic backup** is then sent to the `upgrade platform <https://www.upgrade.odoo.com>`_ 
+        The **latest production daily automatic backup** is then sent to the `upgrade platform <https://www.upgrade.odoo.com>`_
 
         Once the upgrade platform finished upgrading the backup and uploading it on the branch, it is now in a **special mode**: each time a **commit is pushed** on the branch, a **restore operation** of the upgraded backup occurs, and an **update of all the custom modules** happens. This allows you to quickly iterate on your custom modules upgrade scripts. The log file of the upgrade process can be found at :file:`~/logs/upgrade.log` in your newly upgraded staging build.
 
@@ -104,7 +103,7 @@ Where the standard upgrade scripts consists of a sequence of :ref:`reference/upg
     .. group-tab:: On-Premise
 
         .. _upgrade/request-test-database/on-premise:
-        
+
         The standard upgrade process can be initiated via the following command line on the machine where the database is hosted:
         `python <(curl -s https://upgrade.odoo.com/upgrade) test -d <your db name> -t <target version>`
 
@@ -150,7 +149,7 @@ Test databases are neutered and some features are disabled to prevent them from
     - Are your usual views still displayed correctly ?
     - Are your reports (Invoice, Sales Order, etc.) correctly generated ?
     - Are your website pages working correctly ?
-    - Are you able to create and modify records ? (Sales order, invoices, purchases, users, contacts, companies, etc ... ) 
+    - Are you able to create and modify records ? (Sales order, invoices, purchases, users, contacts, companies, etc ... )
     - Is there any issues with your mail templates ?
     - Are your search filters still present ?
     - Can you export your data ?
@@ -173,7 +172,7 @@ It is strongly receommend to test as many of your business flows as possible to
     - Randomly check your taxes, currencies, Bank Account. Is your fiscal year set in production database the same? (only available with Accounting Apps);
     - Proceed to an online order (only available with Website Apps) from the product selection in your shop until the checkout process and check if its behaves as your production database.
 
-    Depending on the complexity of your database, you also shouldn't forget to test : 
+    Depending on the complexity of your database, you also shouldn't forget to test :
 
     - Integrations with external softwares (EDI, APIs, ...)
     - Workflows between different Apps (online sales with eCommerce, converting a lead all the way to a sales order, delivery of products, etc ... )
@@ -228,7 +227,7 @@ The process of upgrading a database to production is similar to the one of upgra
         The update of your custom modules must be successful to complete the entire upgrade process. Make sure the status of your staging upgrade is :guilabel:`successful` before trying it in production. More information on how to upgrade your custom modules can be found in :ref:`upgrade/upgrading_customizations`.
 
     .. group-tab:: On-Premise
-        
+
         The command to upgrade a database to production is similar to the one of upgrading a test database except for the argument ``test`` which must be replaced by ``production``.
         `python <(curl -s https://upgrade.odoo.com/upgrade) production -d <your db name> -t <target version>`
 
@@ -246,6 +245,7 @@ In case of an issue with your production database, you can request the assistanc
 
 Comparing customizations to the new version
 -------------------------------------------
+
 During an upgrade, it is very likely that in the plethora of new features added in the years of development between 2 versions, what was added in your database as a customization might be part of the standard of Odoo now.
 
 Therefore, it is recommended to take the time to explore the new features of Odoo and to compare them with the current customizations implemented. This might allow you to remove some of the customizations that are now part of the standard of Odoo and to reduce the amount of work needed to maintain and upgrade your database.
@@ -270,7 +270,7 @@ This feature allows customers to upgrade their database directly from a message
 
 #. To 'Upgrade Now', which immediately triggers the upgrade of your live production database. (Discouraged)
 
-#. To take you to your `database manager <https://www.odoo.com/my/databases/>` where you can `request an upgraded test database <https://upgrade.odoo.com/#online/>`_ and check the upgraded test database for any discrepancies. (Recommended)
+#. To take you to your `database manager <https://www.odoo.com/my/databases/>`_ where you can `request an upgraded test database <https://upgrade.odoo.com/#online/>`_ and check the upgraded test database for any discrepancies. (Recommended)
 
 If a database cannot be successfully upgraded automatically, then a ticket is automatically created to allow the upgrade technicians of Odoo to investigate the issue and fix it. Once the issue is fixed, the database is unblocked from the process and is available to be tested automatically again
 
@@ -311,4 +311,4 @@ Why can't you make my view be exactly like it was before ?
 
 With each new version of Odoo, standard views, features, fields, and models are changed to improve the user experience and the performance of the application. Therefore, asking the upgrade team to downgrade a feature of your database so that it matches the previous version of Odoo is not possible, as it would cancel out the benefits of the upgrade.
 
-However, if you are paying Odoo for the maintenance of your customizations and that the view in question is part of it, in case of issues with that view during the upgrade, Odoo will take care of fixing the customization so that it becomes compatible with the new version of Odoo.
+However, if you are paying Odoo for the maintenance of your customizations and that the view in question is part of it, in case of issues with that view during the upgrade, Odoo will take care of fixing the customization so that it becomes compatible with the new version of Odoo.
diff --git a/content/developer/reference/cli.rst b/content/developer/reference/cli.rst
@@ -679,7 +679,7 @@ This enables direct interaction with the :ref:`orm <reference/orm>` and its func
            ...:
 
         In [4]: env.cr.commit()
-    
+
     .. important::
         By default, the shell is running in transaction mode. This means that any change made to the database will be rolled back when exiting the shell. To commit changes, use ``env.cr.commit()``.
 
diff --git a/content/developer/reference/upgrade.rst b/content/developer/reference/upgrade.rst
@@ -71,7 +71,7 @@ Positioning a migration script
 
 Migration scripts are executed depending on their module, the version of Odoo, the version of the module, the phase of the migration script, and finally its name. The path of a migration script is as follows:
 
-`<module_name>/migrations/<major_version>.<minor_version>/{pre|post|end}-*.py``
+`<module_name>/migrations/<major_version>.<minor_version>/{pre|post|end}-*.py`
 
 - `<module_name>` Corresponds to the name of the folder of a module. For example `account` for the Accounting module, or `sale_subscription` for the Subscription module.
 
@@ -94,7 +94,7 @@ Phases of migration scripts
 
 The upgrade process consists of three phases for each version of each module. It starts with the pre-phase, followed by post- and then end-. Migration scripts are grouped according to the first part of their filenames into the corresponding phase.
 
-The pre-phase is executed before the module and its dependencies are loaded, meaning that you cannot use the ORM to access any model or record, but executing PSQL queries in that phase is possible. The post-phase is executed after the module and its dependencies are loaded and upgraded. At that time, the ORM becomes available and you can refer any model or record. 
+The pre-phase is executed before the module and its dependencies are loaded, meaning that you cannot use the ORM to access any model or record, but executing PSQL queries in that phase is possible. The post-phase is executed after the module and its dependencies are loaded and upgraded. At that time, the ORM becomes available and you can refer any model or record.
 
 The end-phase is a little bit different, as it is executed after all modules have been upgraded for the major version. This phase is useful to perform operations that require the whole database to be upgraded, or to perform operations for which the order is not important such as modifying views.
 
@@ -144,7 +144,7 @@ Upgrading custom fields and their data
 During an upgrade, standard fields can be renamed or moved, in which cases any custom field that has a reference to them must be adapted to the new version of Odoo. To do so, we recommend looking at the properties of the field in the current version of Odoo, and match them with the properties of the fields in the new version of Odoo to find the new name of the field.
 
 .. example::
-    In Odoo 12 and before, the model `account.invoice` had a field named `refund_invoice_id` (`source code <https://github.com/odoo/odoo/blob/f7431b180834a73fe8d3aed290c275cc6f8dfa31/addons/account/models/account_invoice.py#L273>`) which cannot is absent on the model `account.move` after Odoo 13. This field was actually renamed to `reversed_entry_id` during the upgrade process. It is possible to find this information by searching for another Many2one field in `account.move` that is related to `account.move` in the upgraded version of Odoo.
+    In Odoo 12 and before, the model `account.invoice` had a field named `refund_invoice_id` (`source code <https://github.com/odoo/odoo/blob/f7431b180834a73fe8d3aed290c275cc6f8dfa31/addons/account/models/account_invoice.py#L273>`_) which is absent on the model `account.move` after Odoo 13. This field was actually renamed to `reversed_entry_id` during the upgrade process. It is possible to find this information by searching for another Many2one field in `account.move` that is related to `account.move` in the upgraded version of Odoo, for example in `Odoo 16 <https://github.com/odoo/odoo/blob/a0c1e2aa602ae46598a350ea6ae8d8b4a0c1c823/addons/account/models/account_move.py#L453>_`.
 
 .. important::
     When changing the name of fields in the code, their data stored in a PSQL column must be moved with :ref:`migration scripts <reference/upgrade/migration-scripts>` to the new column. Furthermore, fields can also be referenced in other parts of the database such as automated actions, views, reports, etc ... which can be stored in the database independently from the code that also needs to be moved.
@@ -250,7 +250,7 @@ Unarchiving the view in your database will trigger the validation error if the v
             xmlid: studio_customization.odoo_studio_crm_lead_378fc723-a146-2f5b-b6a7-a2f7e15922f8
             view.model: crm.lead
             view.parent: ir.ui.view(902,)
-            
+
             2023-09-04 15:04:34,315 28 WARNING db_1146520 odoo.addons.base.maintenance.migrations.base.pre-models-ir_ui_view: The custom view `Odoo Studio: crm.lead.tree.opportunity customization` (ID: 1137, Inherit: 902, Model: crm.lead) caused validation issues.
             Disabling it for the migration ...
 
