-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[IMP] CRM: update multiple sales teams doc #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
meng-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StraubCreative Hi Zach! I made tons of changes to VPK's content on this doc, especially since you suggested I edit to make it shorter/clearer/more concise. Please let me know if you have any questions/comments about my changes below :) Thanks
9e9a937 to
8824706
Compare
|
Sorry, I didn't know about this PR and had to retrieve its information, you may have to re-approve it. |
|
Hi @meng-odoo Good first pass 👍 For next round of review, I highly suggest reworking the tense and tone for the whole document, namely:
Looking forward to your thoughts and further improvements as you see fit! |
meng-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StraubCreative Hi Zac! Thanks for your feedback on my first review--I'll keep all of that in mind when writing my future reviews as well.
I think this one makes a lot of improvements :) Please let me know if you have any more suggestions.
8824706 to
e8d2765
Compare
|
@meng-odoo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StraubCreative Thanks Zac! Everything looks good to me. I'll go ahead and tag Doc Review :)
AntoineVDV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! 👌
@robodoo r+
|
Because this PR has multiple commits, I need to know how to merge it:
|
|
@meng-odoo @StraubCreative could you just squash the two commits into one so that the PR can be merged? |
Task: 2588786
e8d2765 to
85e0b9f
Compare
Should be good to go @AntoineVDV 🚀 |
|
@robodoo r+ |
closes #1056 Task: 2588786 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Associated task: https://www.odoo.com/web#id=2588786&action=333&active_id=3835&model=project.task&view_type=form&cids=3&menu_id=4720