Skip to content

Conversation

@dinakdugar
Copy link
Contributor

Per SME feedback: Removing admonition on FBM/FMA stock synchronization in Amazon Connector documentation as it no longer applies.

Task: https://www.odoo.com/odoo/my-tasks/4485303

@robodoo
Copy link
Collaborator

robodoo commented Jan 16, 2025

Pull request status dashboard

@dinakdugar dinakdugar self-assigned this Jan 16, 2025
@dinakdugar dinakdugar added the 1 label Jan 16, 2025
@dinakdugar
Copy link
Contributor Author

Hi @benderliz this PR is ready for peer review, when you have a chance! Should be quick, only removed an admonition block that is no longer applicable in 18.0 -- but let me know if you have any questions!

@C3POdoo C3POdoo requested a review from a team January 16, 2025 22:29
Copy link
Contributor

@benderliz benderliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, Dina! You removed that admonition block like it was your job! (I guess technically it is.)

@dinakdugar
Copy link
Contributor Author

Thank you for the review, @benderliz! ٩(ˊᗜˋ*)و ♡

Hi @Felicious this PR is ready for final review, when you have a chance. Thank you!

@dinakdugar dinakdugar closed this Jan 16, 2025
@dinakdugar dinakdugar reopened this Jan 16, 2025
@dinakdugar dinakdugar force-pushed the 18.0-sales-amazon-connector-dikd branch from c565dfb to bf39e30 Compare January 16, 2025 23:10
@dinakdugar dinakdugar changed the title [IMP] Changing the warning message for Amazon connector [IMP] sales: Changing the warning message for Amazon connector Jan 16, 2025
@dinakdugar dinakdugar requested a review from Felicious January 17, 2025 00:16
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time, feel free to expedite 1 pt PRs to Sam directly, @dikd-odoo (: The peer --> final review system is for content changes 😊

Also, why does the commit message say "change the warning message" when we've removed it? Would "remove the warning message" be more accurate?

@dinakdugar dinakdugar force-pushed the 18.0-sales-amazon-connector-dikd branch from bf39e30 to ebc789c Compare January 17, 2025 00:42
@dinakdugar dinakdugar changed the title [IMP] sales: Changing the warning message for Amazon connector [IMP] sales: removing the warning message for Amazon connector Jan 17, 2025
@dinakdugar
Copy link
Contributor Author

Thank you @Felicious! Will tag Sam directly for future 1-point PRs. Also changed the commit name to be more accurate.

Hi @samueljlieber this PR is ready for tech review, when you have a chance. Thank you!

@dinakdugar dinakdugar requested review from a team and samueljlieber January 17, 2025 00:48
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @dikd-odoo! Thank you!
.
@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants