- 
                Notifications
    You must be signed in to change notification settings 
- Fork 10.4k
[IMP] sales: removing the warning message for Amazon connector #11773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Hi @benderliz this PR is ready for peer review, when you have a chance! Should be quick, only removed an admonition block that is no longer applicable in 18.0 -- but let me know if you have any questions! | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, Dina! You removed that admonition block like it was your job! (I guess technically it is.)
| Thank you for the review, @benderliz! ٩(ˊᗜˋ*)و ♡ Hi @Felicious this PR is ready for final review, when you have a chance. Thank you! | 
c565dfb    to
    bf39e30      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next time, feel free to expedite 1 pt PRs to Sam directly, @dikd-odoo (: The peer --> final review system is for content changes 😊
Also, why does the commit message say "change the warning message" when we've removed it? Would "remove the warning message" be more accurate?
bf39e30    to
    ebc789c      
    Compare
  
    | Thank you @Felicious! Will tag Sam directly for future 1-point PRs. Also changed the commit name to be more accurate. Hi @samueljlieber this PR is ready for tech review, when you have a chance. Thank you! | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @dikd-odoo! Thank you!
.
@robodoo r+

Per SME feedback: Removing admonition on FBM/FMA stock synchronization in Amazon Connector documentation as it no longer applies.
Task: https://www.odoo.com/odoo/my-tasks/4485303