[IMP] Payroll: Updating work entries #14498
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Contributor
Author
|
Hi @jero-odoo - this is ready for a peer review - thanks! |
jero-odoo
approved these changes
Sep 5, 2025
Contributor
jero-odoo
left a comment
jero-odoo
left a comment
There was a problem hiding this comment.
Looks good to me @larm-odoo just a few notes.
Also-it looks like there are a lot of extra images in the folder that are not included in the doc, they should be removed before you publish. Thanks!
larm-odoo
force-pushed
the
18.0-payroll-update-work-entries-larm
branch
2 times, most recently
from
d433758 to
ea6eb35
Compare
Contributor
Author
|
Hi @Felicious - this is ready for a final review! |
Felicious
approved these changes
Sep 10, 2025
Contributor
Felicious
left a comment
Felicious
left a comment
There was a problem hiding this comment.
LGTM, @larm-odoo ! I found minor nitpicks in a sentence or two, but nothing substantial! All optional (:
@robodoo delegate+
larm-odoo
force-pushed
the
18.0-payroll-update-work-entries-larm
branch
from
ea6eb35 to
4a11b37
Compare
larm-odoo
force-pushed
the
18.0-payroll-update-work-entries-larm
branch
from
4a11b37 to
2344c11
Compare
Contributor
Author
|
@robodoo r+ |
This was referenced Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to new standards, updating images, removing old batches and payroll generation sections (they are covered in the Batches document) and also the Defer Time Off - this will be in a new doc.
Original task card for this PR.