-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[ADD] journals: explain journals and accounts #14503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3041bae to
2a19860
Compare
2a19860 to
07fe603
Compare
07fe603 to
342ef51
Compare
xpl-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR @dade-odoo, getting the accounting basics right is important - curious to see the rest :)
content/applications/finance/accounting/get_started/journals.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/get_started/journals.rst
Outdated
Show resolved
Hide resolved
| - :guilabel:`Currency`: If desired, set the currency of this journal. For bank and cash journals, | ||
| this is the currency of the journal's :doc:`transactions <../bank/transactions>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this field is only available for multi-company DBs (maybe for branches as well?). We usually don't cover multi-company options, but you could add it if you feel it's particularly important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually not about multi-company but just about having multiple currencies enabled. I'm adding another line to clarify that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, I couldn't get the currency field to show on my 18.0 trial DB (single company), even after enabling multiple currencies. I had to have a second company for it to appear. But that's possibly a bug and not something desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It worked for me. You might need to refresh after enabling the second currency :)
content/applications/finance/accounting/get_started/journals.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/get_started/journals.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/get_started/journals.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/get_started/chart_of_accounts.rst
Outdated
Show resolved
Hide resolved
342ef51 to
b0a5871
Compare
dade-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @xpl-odoo , thanks for the review. Let me know what you think about the few issues I've left open :)
| - :guilabel:`Currency`: If desired, set the currency of this journal. For bank and cash journals, | ||
| this is the currency of the journal's :doc:`transactions <../bank/transactions>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually not about multi-company but just about having multiple currencies enabled. I'm adding another line to clarify that.
content/applications/finance/accounting/get_started/journals.rst
Outdated
Show resolved
Hide resolved
| When a bank transaction is reconciled, the journal entry is modified to replace the bank | ||
| suspense account with the account of the journal item it is reconciled with. This account is | ||
| usually the :ref:`outstanding receipts or payments account | ||
| <accounting/journals/outstanding-accounts>` if reconciling with a registered payment or the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree on the comma, but I've restructured it to make it more clear. Let me know what you think.
xpl-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm delegating in case you'd like to make any changes. Nice work! :)
@robodoo delegate+
| - :guilabel:`Currency`: If desired, set the currency of this journal. For bank and cash journals, | ||
| this is the currency of the journal's :doc:`transactions <../bank/transactions>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, I couldn't get the currency field to show on my 18.0 trial DB (single company), even after enabling multiple currencies. I had to have a second company for it to appear. But that's possibly a bug and not something desired.
content/applications/finance/accounting/get_started/journals.rst
Outdated
Show resolved
Hide resolved
| When a bank transaction is reconciled, the journal entry is modified to replace the bank | ||
| suspense account with the account of the journal item it is reconciled with. This account is | ||
| usually the :ref:`outstanding receipts or payments account | ||
| <accounting/journals/outstanding-accounts>` if reconciling with a registered payment or the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to add too many commas, but shouldn't you add a comma before the second or?
It's perfect like that in any case.
task-3991940
b0a5871 to
1d051f2
Compare
|
@robodoo r+ |
task-3991940 closes #14503 Signed-off-by: Dallas Dean (dade) <dade@odoo.com>
task-3991940 closes #14503 Signed-off-by: Dallas Dean (dade) <dade@odoo.com>

task-3991940