Skip to content

Conversation

@dade-odoo
Copy link
Contributor

task-3991940

@robodoo
Copy link
Collaborator

robodoo commented Sep 5, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team September 5, 2025 11:39
@C3POdoo C3POdoo requested review from a team September 5, 2025 13:31
@dade-odoo dade-odoo removed request for a team September 5, 2025 13:44
@dade-odoo dade-odoo requested a review from a team September 8, 2025 07:53
@AntoineVDV AntoineVDV removed the request for review from a team September 8, 2025 08:30
@xpl-odoo xpl-odoo requested review from xpl-odoo and removed request for a team September 8, 2025 09:30
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR @dade-odoo, getting the accounting basics right is important - curious to see the rest :)

Comment on lines 36 to 37
- :guilabel:`Currency`: If desired, set the currency of this journal. For bank and cash journals,
this is the currency of the journal's :doc:`transactions <../bank/transactions>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this field is only available for multi-company DBs (maybe for branches as well?). We usually don't cover multi-company options, but you could add it if you feel it's particularly important.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually not about multi-company but just about having multiple currencies enabled. I'm adding another line to clarify that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, I couldn't get the currency field to show on my 18.0 trial DB (single company), even after enabling multiple currencies. I had to have a second company for it to appear. But that's possibly a bug and not something desired.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked for me. You might need to refresh after enabling the second currency :)

Copy link
Contributor Author

@dade-odoo dade-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xpl-odoo , thanks for the review. Let me know what you think about the few issues I've left open :)

Comment on lines 36 to 37
- :guilabel:`Currency`: If desired, set the currency of this journal. For bank and cash journals,
this is the currency of the journal's :doc:`transactions <../bank/transactions>`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually not about multi-company but just about having multiple currencies enabled. I'm adding another line to clarify that.

When a bank transaction is reconciled, the journal entry is modified to replace the bank
suspense account with the account of the journal item it is reconciled with. This account is
usually the :ref:`outstanding receipts or payments account
<accounting/journals/outstanding-accounts>` if reconciling with a registered payment or the
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree on the comma, but I've restructured it to make it more clear. Let me know what you think.

@dade-odoo dade-odoo requested a review from xpl-odoo September 26, 2025 06:29
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm delegating in case you'd like to make any changes. Nice work! :)

@robodoo delegate+

Comment on lines 36 to 37
- :guilabel:`Currency`: If desired, set the currency of this journal. For bank and cash journals,
this is the currency of the journal's :doc:`transactions <../bank/transactions>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, I couldn't get the currency field to show on my 18.0 trial DB (single company), even after enabling multiple currencies. I had to have a second company for it to appear. But that's possibly a bug and not something desired.

When a bank transaction is reconciled, the journal entry is modified to replace the bank
suspense account with the account of the journal item it is reconciled with. This account is
usually the :ref:`outstanding receipts or payments account
<accounting/journals/outstanding-accounts>` if reconciling with a registered payment or the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to add too many commas, but shouldn't you add a comma before the second or?
It's perfect like that in any case.

@dade-odoo
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Sep 30, 2025
task-3991940

closes #14503

Signed-off-by: Dallas Dean (dade) <dade@odoo.com>
robodoo pushed a commit that referenced this pull request Sep 30, 2025
task-3991940

closes #14503

Signed-off-by: Dallas Dean (dade) <dade@odoo.com>
@robodoo robodoo closed this Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants