Extend internationalization guide for javascript translations #1710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mart-e
reviewed
Mar 18, 2022
In order for javascript translations to become active, the corresponding addon needs to follow a certain naming scheme or register explicitly. This commit updates the internationalization guide with a respective hint. Fixes odoo#1676
mart-e
force-pushed
the
improved-translation-guide
branch
from
b8f0dd6 to
8a751da
Compare
mart-e
approved these changes
Mar 18, 2022
Contributor
mart-e
left a comment
mart-e
left a comment
There was a problem hiding this comment.
Thanks for the quick changes.
I have changed the commit to follow the commit message guidelines but should be good now.
@robodoo r+
Collaborator
|
I'm sorry, @mart-e. I'm afraid I can't do that. |
Contributor
|
@robodoo sudo r+ ? 🤷♂️ |
Collaborator
|
I'm sorry, @mart-e. I'm afraid I can't do that. |
Contributor
|
@robodoo r+ pretty please 🙏 |
This was referenced Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for javascript translations to become active, the corresponding
addon needs to follow a certain naming scheme or register explicitly.
This commit updates the internationalization guide with a respective
hint.
This PR targets the Odoo 14.0 branch since this is the version I'm working on but should as well work for Odoo 15.0
See #1676