Skip to content

Conversation

@Yenthe666
Copy link
Contributor

Since there was zero info/documentation about how to setup multi website with multiple (sub)domains I've added some notes to explain what has to be done.

@robodoo
Copy link
Collaborator

robodoo commented Apr 21, 2022

@C3POdoo C3POdoo requested a review from a team April 21, 2022 16:00
@Yenthe666
Copy link
Contributor Author

@mart-e who can manage this one? Not sure :)

@Yenthe666
Copy link
Contributor Author

@Lau-Odoo who can merge this in? 🤔

@Lau-Odoo
Copy link
Contributor

Hi @Yenthe666, sorry, I thought that the request for the technical review was automated 😅

@Lau-Odoo Lau-Odoo requested a review from AntoineVDV April 27, 2022 12:33
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, please find my technical review comments below.

@Yenthe666
Copy link
Contributor Author

@AntoineVDV okay changes done! I believe this should do it? :)

Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntoineVDV okay changes done! I believe this should do it? :)

Almost, but as you can see on the bottom of this page, the runbot build is red because you didn't indent the continuation lines properly. If you log in on the failing ci/documentation build you will see that the list is not rendered the way you'd expect it to be. Sphinx is quite strict with indentations and spaces in general; it expects the continuation line to be aligned with the first character of the list item above.

@Yenthe666
Copy link
Contributor Author

@AntoineVDV thanks for the feedbacks! Reworked, I hope I did all good now :)

Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, LGTM now :)

@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 28, 2022
closes #1843

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
@robodoo robodoo closed this Apr 28, 2022
@robodoo robodoo temporarily deployed to merge April 28, 2022 14:31 Inactive
@Yenthe666 Yenthe666 deleted the 13-website-domain-info branch April 28, 2022 14:45
@Yenthe666
Copy link
Contributor Author

Thanks :) How do I know when it lands on https://www.odoo.com/documentation/13.0/applications/websites/website/publish/multi_website.html actually?

@AntoineVDV
Copy link
Collaborator

Thanks :) How do I know when it lands on https://www.odoo.com/documentation/13.0/applications/websites/website/publish/multi_website.html actually?

The documentation is built overnight every day so just check tomorrow and it should be there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants