-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[ADD] multi_website: add info to configure multiple domains #1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mart-e who can manage this one? Not sure :) |
|
@Lau-Odoo who can merge this in? 🤔 |
|
Hi @Yenthe666, sorry, I thought that the request for the technical review was automated 😅 |
AntoineVDV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, please find my technical review comments below.
content/applications/websites/website/publish/multi_website.rst
Outdated
Show resolved
Hide resolved
content/applications/websites/website/publish/multi_website.rst
Outdated
Show resolved
Hide resolved
|
@AntoineVDV okay changes done! I believe this should do it? :) |
AntoineVDV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AntoineVDV okay changes done! I believe this should do it? :)
Almost, but as you can see on the bottom of this page, the runbot build is red because you didn't indent the continuation lines properly. If you log in on the failing ci/documentation build you will see that the list is not rendered the way you'd expect it to be. Sphinx is quite strict with indentations and spaces in general; it expects the continuation line to be aligned with the first character of the list item above.
content/applications/websites/website/publish/multi_website.rst
Outdated
Show resolved
Hide resolved
content/applications/websites/website/publish/multi_website.rst
Outdated
Show resolved
Hide resolved
|
@AntoineVDV thanks for the feedbacks! Reworked, I hope I did all good now :) |
AntoineVDV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, LGTM now :)
@robodoo r+
closes #1843 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
|
Thanks :) How do I know when it lands on https://www.odoo.com/documentation/13.0/applications/websites/website/publish/multi_website.html actually? |
The documentation is built overnight every day so just check tomorrow and it should be there. |
Since there was zero info/documentation about how to setup multi website with multiple (sub)domains I've added some notes to explain what has to be done.