[ADD] Sales: loyalty and discount programs #3587
Conversation
toaa-odoo
force-pushed
the
16.0-loyalty-toaa
branch
2 times, most recently
from
4b61954 to
37ac62b
Compare
toaa-odoo
changed the title
toaa-odoo
force-pushed
the
16.0-loyalty-toaa
branch
3 times, most recently
from
22218dc to
fe00818
Compare
meng-odoo
force-pushed
the
16.0-loyalty-toaa
branch
from
fe00818 to
ce95e0e
Compare
|
Thank you for creating this doc @toaa-odoo! I added information and edited the formatting and wording in the latest commit. Now tagging @odoo/us-doc-review for content review :) |
ksc-odoo
left a comment
ksc-odoo
left a comment
There was a problem hiding this comment.
@toaa-odoo @meng-odoo just finished my peer review. Great work! if you have any questions, or need clarification on any of the suggested edits, just drop me a message! Once again, fantastic job on this!
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
meng-odoo
force-pushed
the
16.0-loyalty-toaa
branch
from
ce95e0e to
285d897
Compare
|
Thanks for the review @ksc-odoo! I've incorporated your suggestions. Hi @samueljlieber, this doc is ready for technical review. |
There was a problem hiding this comment.
Hi @toaa-odoo 👋 I have a few technical changes on this PR. Please see my suggestions below and let me know if you have any questions, otherwise I look forward to seeing your changes 🙂
Note on images: most of the images in this PR are too wide, please resize them before compression to be at maximum under 933px wide or ideally under 768px wide
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
meng-odoo
force-pushed
the
16.0-loyalty-toaa
branch
from
6a30e63 to
dd8c2ba
Compare
|
Thanks for the review @samueljlieber! I've taken over this doc, so no need to tag @toaa-odoo anymore, sorry for the confusion :) I've incorporated your changes, this is ready for a second review. |
samueljlieber
left a comment
samueljlieber
left a comment
There was a problem hiding this comment.
Hi @meng-odoo 👋 just a couple more technical changes and we should be good to go with this PR. Please see my suggestions below to just update one doc path reference as well as all of the alt tags in the PR. Great job with the changes 🙂 let me know if you have any questions!
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/loyalty_discount.rst
Outdated
Show resolved
Hide resolved
meng-odoo
force-pushed
the
16.0-loyalty-toaa
branch
from
dd8c2ba to
3cae8a3
Compare
|
Thanks @samueljlieber, I've made your suggested changes in the latest commit. Please let me know if you have any more suggestions :) |
|
Looks good to me @meng-odoo, nice job 🙂 @StraubCreative this PR is ready for your final review! |
StraubCreative
left a comment
StraubCreative
left a comment
There was a problem hiding this comment.
Hi everyone,
Great doc. 👏
I just had a few suggestions for your consideration, however we're good to merge here whenever you like!
@robodoo delegate=meng-odoo
|
@robodoo r+ |
|
@toaa-odoo @meng-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
Adding a doc on loyalty and discount programs. Forward to master.
taskid: 3213170