Skip to content

[IMP] Inventory: updated for v16 #4379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] Inventory: updated for v16 #4379

wants to merge 1 commit into from

Conversation

@larm-odoo
Copy link
Contributor

@larm-odoo larm-odoo commented May 9, 2023

Made targeted updates for V16 (no "create" or "edit" buttons for example)

@robodoo
Copy link
Collaborator

robodoo commented May 9, 2023

Pull request status dashboard.

@larm-odoo larm-odoo requested a review from a team May 9, 2023 16:16
@C3POdoo C3POdoo requested a review from a team May 9, 2023 16:17
ksc-odoo
ksc-odoo reviewed May 9, 2023
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larm-odoo just finished a peer review of this doc - awesome work. If you have any questions or need clarification on anything - just let me know. Also, feel free to re-tag me once these changes have been made so we can make sure everything is good to go before moving it on to Tech Review. Thanks!

@larm-odoo larm-odoo force-pushed the 16.0-Inventory-update-for-16-edits-larm branch from bd0836f to c6abc94 Compare May 10, 2023 15:08
@larm-odoo larm-odoo requested a review from ksc-odoo May 10, 2023 15:09
@larm-odoo
Copy link
Contributor Author

larm-odoo commented May 10, 2023

Thanks for the review @ksc-odoo! I made the edits, or commented in the appropriate field. It's ready for another look now =)

ksc-odoo
ksc-odoo reviewed May 10, 2023
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larm-odoo looks good 👍

@larm-odoo
Copy link
Contributor Author

larm-odoo commented May 11, 2023 •
edited
Loading

Thanks @ksc-odoo! Looks like this is ready for @StraubCreative next.

@larm-odoo larm-odoo requested a review from StraubCreative May 11, 2023 19:13
@StraubCreative StraubCreative requested review from samueljlieber and removed request for StraubCreative May 19, 2023 01:02
@StraubCreative
Copy link
Contributor

StraubCreative commented May 19, 2023

@samueljlieber can you take a peek first please and make sure this is g2g?
TIA!

samueljlieber
samueljlieber requested changes May 19, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @larm-odoo this PR is looking great! I have one small technical change, please tag me once more after this change is made :)

...cations/inventory_and_mrp/inventory/management/shipments_deliveries/delivery_three_steps.rst Outdated
:menuselection:`Inventory --> Configuration --> Warehouses`, and click :guilabel:`Edit` to edit the
:guilabel:`Warehouse`. Then, select :guilabel:`Pack goods, send goods in output and then deliver
(3 steps)` for :guilabel:`Outgoing Shipments`. Then :guilabel:`Save` the changes.
:menuselection:`Inventory app --> Configuration --> Warehouses`, and click on the warehouse to edit.
Copy link
Contributor

@samueljlieber samueljlieber May 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that warehouse may need a guilabel since it is part of the active instruction

Suggested change
:menuselection:`Inventory app --> Configuration --> Warehouses`, and click on the warehouse to edit.
:menuselection:`Inventory app --> Configuration --> Warehouses`, and click on the :guilabel:`warehouse` to edit.

@larm-odoo larm-odoo force-pushed the 16.0-Inventory-update-for-16-edits-larm branch from c6abc94 to 48b8d53 Compare May 19, 2023 16:40
@larm-odoo
Copy link
Contributor Author

larm-odoo commented May 19, 2023

All set @samueljlieber!

@larm-odoo larm-odoo requested a review from samueljlieber May 19, 2023 16:41
samueljlieber
samueljlieber approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @larm-odoo, the changes in this PR look good to me! Nice job! Passing to @StraubCreative for final review

@Felicious Felicious removed the request for review from a team August 16, 2023 23:43
@meng-odoo meng-odoo requested a review from a team December 20, 2023 00:25
meng-odoo
meng-odoo approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@meng-odoo meng-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @larm-odoo, your changes to this doc look good! I'm approving the content, but there's a build warning. Can you or @samueljlieber please fix before merging? Thank you :)

@StraubCreative StraubCreative force-pushed the 16.0-Inventory-update-for-16-edits-larm branch from 48b8d53 to 3a9bccf Compare December 20, 2023 00:34
@StraubCreative
Copy link
Contributor

StraubCreative commented Dec 20, 2023

Cherry-pick in 3a9bccf resolves merge conflict due to #5700 .

All checks pass ✅

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Dec 20, 2023

@larm-odoo @StraubCreative staging failed: ci/runbot on bb13d30cc1cc82edd97959dc4e9d34ea810624c4 (view more at https://runbot.odoo.com/runbot/build/55372595)

@StraubCreative
Copy link
Contributor

StraubCreative commented Dec 20, 2023

@robodoo retry

robodoo pushed a commit that referenced this pull request Dec 20, 2023
@larm-odoo @StraubCreative
[IMP] Inventory: updated for v16
3b7bb8c 
closes #4379

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
@robodoo
Copy link
Collaborator

robodoo commented Dec 20, 2023

@larm-odoo @StraubCreative staging failed: ci/runbot on 23ba3f06862e7787fe6b67d99bdae927d9f6cc63 (view more at https://runbot.odoo.com/runbot/build/55374934)

@StraubCreative
Copy link
Contributor

StraubCreative commented Dec 20, 2023

@robodoo retry

robodoo pushed a commit that referenced this pull request Dec 20, 2023
@larm-odoo @StraubCreative
[IMP] Inventory: updated for v16
1c00f06 
closes #4379

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
@robodoo robodoo closed this Dec 20, 2023
This was referenced Dec 20, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueljlieber samueljlieber samueljlieber approved these changes

+2 more reviewers

@ksc-odoo ksc-odoo ksc-odoo left review comments

@meng-odoo meng-odoo meng-odoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@larm-odoo @robodoo @StraubCreative @samueljlieber @ksc-odoo @meng-odoo