Skip to content

[IMP] Sales - updated Deadline.rst (v14) #4424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] Sales - updated Deadline.rst (v14) #4424

wants to merge 1 commit into from

Conversation

@ksc-odoo
Copy link
Contributor

@ksc-odoo ksc-odoo commented May 12, 2023 •
edited
Loading

updated the Quotation Deadline doc to adhere to recent RST formatting decisions

project task: https://www.odoo.com/web#id=3329160&cids=3&menu_id=4720&action=333&active_id=3835&model=project.task&view_type=form

@ksc-odoo ksc-odoo requested review from a team, StraubCreative and samueljlieber May 12, 2023 21:53
@ksc-odoo ksc-odoo self-assigned this May 12, 2023
@robodoo
Copy link
Collaborator

robodoo commented May 12, 2023

Pull request status dashboard.

@C3POdoo C3POdoo requested a review from a team May 12, 2023 21:54
@StraubCreative
Copy link
Contributor

StraubCreative commented May 12, 2023

Let's have @hojo-odoo or @meng-odoo take a look first before Sam/me 🙂
FYI take a look at line 46, looks like a typo on a gui according to the CI check log: https://runbot.odoo.com/runbot/build/36214886

hojo-odoo
hojo-odoo reviewed May 15, 2023
View reviewed changes
Copy link
Contributor

@hojo-odoo hojo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ksc-odoo,

Great job on this! I just had a few minor suggestions.

Thanks,
hojo

@ksc-odoo ksc-odoo force-pushed the 14.0-sales-upgrade-quotation-deadline-rst branch from 20a73db to d3dabf6 Compare May 17, 2023 22:36
@ksc-odoo ksc-odoo requested a review from samueljlieber May 17, 2023 22:36
samueljlieber
samueljlieber requested changes May 18, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo I have a handful of technical changes in this PR, please see below. @ksc-odoo and @hojo-odoo there were also two typos I found, these shouldnt reach me in technical review 🙂. Let me know if you have any questions! Thank you

@ksc-odoo ksc-odoo force-pushed the 14.0-sales-upgrade-quotation-deadline-rst branch from d3dabf6 to 7ed5796 Compare May 18, 2023 17:48
@ksc-odoo
Copy link
Contributor Author

ksc-odoo commented May 18, 2023

Hi @ksc-odoo I have a handful of technical changes in this PR, please see below. @ksc-odoo and @hojo-odoo there were also two typos I found, these shouldnt reach me in technical review 🙂. Let me know if you have any questions! Thank you

Alright @samueljlieber - made all the necessary changes - let me know if there's anything else you need from me. Thanks again! 👍

@ksc-odoo ksc-odoo requested a review from samueljlieber May 18, 2023 17:49
samueljlieber
samueljlieber approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo 👋 this PR looks good to me! Nice job 🙂 passing to @StraubCreative for final review!

@StraubCreative StraubCreative force-pushed the 14.0-sales-upgrade-quotation-deadline-rst branch from 7ed5796 to fbda8b1 Compare June 15, 2023 15:31
@StraubCreative
Copy link
Contributor

StraubCreative commented Jun 15, 2023

Fresh rebase on fbda8b1.

StraubCreative
StraubCreative requested changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo 👋
Couple quick changes here too.
Tag me again when we're ready for another look, thanks!

@ksc-odoo ksc-odoo force-pushed the 14.0-sales-upgrade-quotation-deadline-rst branch from fbda8b1 to 5e645aa Compare June 15, 2023 22:10
@ksc-odoo
Copy link
Contributor Author

ksc-odoo commented Jun 15, 2023

@StraubCreative made all the suggested edits - ready for another quick re-review 👍

@ksc-odoo ksc-odoo requested a review from StraubCreative June 15, 2023 22:13
StraubCreative
StraubCreative approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @ksc-odoo, thanks 👍
@robodoo r+

robodoo pushed a commit that referenced this pull request Aug 8, 2023
@ksc-odoo
[IMP] Sales - updated Deadline.rst (v14)
5f27251 
closes #4424

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
@robodoo robodoo temporarily deployed to merge August 8, 2023 18:27 Inactive
@robodoo robodoo closed this Aug 8, 2023
@fw-bot fw-bot mentioned this pull request Aug 8, 2023
Closed
This was referenced Aug 8, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StraubCreative StraubCreative StraubCreative approved these changes

@samueljlieber samueljlieber samueljlieber approved these changes

+1 more reviewer

@hojo-odoo hojo-odoo hojo-odoo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ksc-odoo ksc-odoo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ksc-odoo @robodoo @StraubCreative @samueljlieber @hojo-odoo