Skip to content

[IMP] sales: updated get signature for validation doc for RST formatting #4460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] sales: updated get signature for validation doc for RST formatting #4460

wants to merge 1 commit into from

Conversation

@ksc-odoo
Copy link
Contributor

@ksc-odoo ksc-odoo commented May 17, 2023 •
edited
Loading

updated RST formatting and compressed images (added additional image, as well) to the "get signature for validation" sales doc for v14 - but should be forward-ported to 15, 16 (and minor modifications and adjustments will be made to those versions in the future)

Project Task: https://www.odoo.com/web#id=3330435&cids=3&menu_id=4720&action=333&active_id=3835&model=project.task&view_type=form

@robodoo
Copy link
Collaborator

robodoo commented May 17, 2023

Pull request status dashboard.

@ksc-odoo ksc-odoo self-assigned this May 17, 2023
@ksc-odoo ksc-odoo requested a review from a team May 17, 2023 18:02
@C3POdoo C3POdoo requested a review from a team May 17, 2023 18:02
@ksc-odoo ksc-odoo force-pushed the 14.0-sales-update-get-signature-validate-doc-ksc branch from deec6cb to 80f6a9a Compare May 18, 2023 18:23
hojo-odoo
hojo-odoo reviewed Jun 13, 2023
View reviewed changes
@ksc-odoo ksc-odoo force-pushed the 14.0-sales-update-get-signature-validate-doc-ksc branch from 80f6a9a to 2ee6f24 Compare June 13, 2023 20:27
@ksc-odoo
Copy link
Contributor Author

ksc-odoo commented Jun 13, 2023

Thanks for the awesome review, @hojo-odoo - made all the necessary adjustments. This doc is now ready for your Technical Review @samueljlieber

@ksc-odoo ksc-odoo requested a review from samueljlieber June 13, 2023 20:30
samueljlieber
samueljlieber requested changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo, nice job! I have just a couple of changes needed, let me know when this PR is ready for another look!

@ksc-odoo ksc-odoo force-pushed the 14.0-sales-update-get-signature-validate-doc-ksc branch from 2ee6f24 to e258e28 Compare June 22, 2023 17:11
@ksc-odoo ksc-odoo requested a review from samueljlieber June 22, 2023 17:14
@ksc-odoo
Copy link
Contributor Author

ksc-odoo commented Jun 22, 2023

Hi @ksc-odoo, nice job! I have just a couple of changes needed, let me know when this PR is ready for another look!

Alrighty, @samueljlieber - this is ready for another quick review, whenever you get a chance. Thanks! 👍

samueljlieber
samueljlieber approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo this PR looks great! Approving now and sending to final review. @StraubCreative this should be a quick merge 🙂

@StraubCreative StraubCreative requested a review from a team July 18, 2023 17:55
meng-odoo
meng-odoo suggested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@meng-odoo meng-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo, this doc looks great! I just had a few tiny changes before we merge. Thanks!

@ksc-odoo ksc-odoo force-pushed the 14.0-sales-update-get-signature-validate-doc-ksc branch from e258e28 to 0057e62 Compare July 31, 2023 23:03
@ksc-odoo
Copy link
Contributor Author

ksc-odoo commented Jul 31, 2023

Hi @ksc-odoo, this doc looks great! I just had a few tiny changes before we merge. Thanks!

@meng-odoo Alrighty - just made all those suggested edits. Thanks for the super-helpful feedback! If there's anything else you need me to do with this doc - just let me know. If not, feel free to merge! Thanks again 👍

@meng-odoo
Copy link
Contributor

meng-odoo commented Aug 1, 2023

@samueljlieber There were only very tiny changes to this PR, but could you please do another quick review before we merge? Thanks so much :)

@meng-odoo meng-odoo requested a review from samueljlieber August 1, 2023 17:22
samueljlieber
samueljlieber approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo this PR looks good to me! Nice job 🙂

@StraubCreative ready for merge 👍 and can be FWP to 15.0 & 16.0.

StraubCreative
StraubCreative approved these changes Aug 5, 2023
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and sweet, nice job @ksc-odoo 👍
Approving with two small comments which can optionally be addressed later

@robodoo r+

content/applications/sales/sales/send_quotations/get_signature_to_validate.rst
top-left corner.

.. image:: get_signature_to_validate/signature_1.png
.. image:: get_signature_to_validate/signature-setting.png
Copy link
Contributor

@StraubCreative StraubCreative Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is "ok" however it's more helpful to include surrounding UI elements to act as directional queues for the reader. Otherwise we're just showing the setting as an "island" and not a part of a "whole" section or dashboard.

content/applications/sales/sales/send_quotations/get_signature_to_validate.rst
feature compared to a traditional process.
The Odoo *Sales* application provides customers with the ability to confirm orders via an online
signature directly on the sales order. Once the sales order is electronically signed by the
customer, the salesperson attached to the sales order is automatically notified that the order is
Copy link
Contributor

@StraubCreative StraubCreative Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

word choice

Suggested change
customer, the salesperson attached to the sales order is automatically notified that the order is
customer, the salesperson assigned to the sales order is automatically notified that the order is

robodoo pushed a commit that referenced this pull request Aug 5, 2023
@ksc-odoo
[IMP] sales: updated get siganture for validation doc for RST formatting
6c38992 
closes #4460

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
@fw-bot fw-bot mentioned this pull request Aug 5, 2023
Closed
@robodoo robodoo temporarily deployed to merge August 5, 2023 01:35 Inactive
@robodoo robodoo closed this Aug 5, 2023
This was referenced Aug 5, 2023
Closed
Closed
This was referenced Aug 5, 2023
Closed
Closed
Closed
Closed
Closed
AntoineVDV pushed a commit that referenced this pull request Aug 7, 2023
@ksc-odoo @AntoineVDV
[IMP] sales: updated get siganture for validation doc for RST formatting
fa3d23b 
closes #4460

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StraubCreative StraubCreative StraubCreative approved these changes

@samueljlieber samueljlieber samueljlieber approved these changes

+2 more reviewers

@hojo-odoo hojo-odoo hojo-odoo left review comments

@meng-odoo meng-odoo meng-odoo requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ksc-odoo ksc-odoo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ksc-odoo @robodoo @meng-odoo @StraubCreative @samueljlieber @hojo-odoo