Skip to content

Conversation

@toaa-odoo
Copy link
Contributor

@toaa-odoo toaa-odoo commented Jul 6, 2023

Adding a page on "Menus" in the "pages" section. #4871 must be merged first, and then rebase this PR.

As of 09/08 (DD/MM), rebuilt with #4871

taskid-3414667

@robodoo
Copy link
Collaborator

robodoo commented Jul 6, 2023

@toaa-odoo toaa-odoo force-pushed the 16.0-menus-toaa branch 3 times, most recently from 793ad3c to a25260a Compare July 6, 2023 13:54
@toaa-odoo toaa-odoo changed the title 16.0 menus toaa [ADD] website: menus page Jul 6, 2023
@auva-odoo auva-odoo marked this pull request as ready for review August 3, 2023 10:59
@C3POdoo C3POdoo requested a review from a team August 3, 2023 11:14
@auva-odoo auva-odoo requested review from Donapi and removed request for a team August 3, 2023 12:13
Copy link
Contributor

@Donapi Donapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tom,
I have a few comments. Let me know if you want to discuss them.

@auva-odoo auva-odoo force-pushed the 16.0-menus-toaa branch 2 times, most recently from aacc30f to df323af Compare August 21, 2023 14:03
@auva-odoo auva-odoo requested a review from Donapi August 21, 2023 14:15
@auva-odoo
Copy link
Contributor

@xpl-odoo I made the changes based on what we discussed :) I'm still not super sure about the section on mega menus, especially the part about adapting the options and layout. I thought it would be useful to keep concrete examples of what you can do, but what do you think?
Also, I wasn't sure how we should refer to 'the Customize tab in the website builder'; this is the actual wording I used, but I'm not 100% convinced: should we just say "in the website builder" or "in the Customize tab", or something else?
Anyways, let me know what you think :)

Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss this :)

@xpl-odoo
Copy link
Contributor

xpl-odoo commented Sep 5, 2023

Feel free to do as you see fit :)

@robodoo delegate+

@auva-odoo
Copy link
Contributor

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Sep 5, 2023

I'm sorry, @auva-odoo. I'm afraid I can't do that.

@xpl-odoo
Copy link
Contributor

xpl-odoo commented Sep 5, 2023

@robodoo delegate=auva-odoo

@auva-odoo
Copy link
Contributor

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Sep 5, 2023

@toaa-odoo @auva-odoo because this PR has multiple commits, I need to know how to merge it:

  • merge to merge directly, using the PR as merge commit message
  • rebase-merge to rebase and merge, using the PR as merge commit message
  • rebase-ff to rebase and fast-forward

taskid-3414667

Co-authored-by: Toaa <toaa@odoo.com>
Co-authored-by: Auva <auva@odoo.com>
@auva-odoo
Copy link
Contributor

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants