-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[IMP] Misc: Login Oauth Azure Edits #5041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you take a quick look at this process as I documented it? I'm missing something as the login is being denied. Thanks, |
ddbe7cd to
8576c72
Compare
|
@StraubCreative This PR is ready for your review. It is a priority PR from the PO. Thanks. |
StraubCreative
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tiku-odoo
Please double-check the whole doc for grammar, 100th char line breaks, and thoroughness in the instructions. I highlighted a few examples below, thanks!
8576c72 to
c739272
Compare
|
@StraubCreative I've re-read the doc for grammar, 100-character line breaks, and thoroughness of instructions. Thank you for your suggestions. I'm really looking forward to pushing this live. Thanks for your additional review! 👍 |
StraubCreative
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tiku-odoo
Try again please.
I'm looking for thoroughness, guided transitions, and specificity in language.
- Label what things are, consistently.
- Guide people, thoroughly, in each instruction and when transitioning to new sections.
- Be exhaustive.
I've labeled a few spots below, but not all.
I want to be able to look at this doc and know exactly what to do, what things are, where they're located, and how all of those things work, even if I know nothing and can't look at screenshots.
The reason we're specific, why we take the time to be thorough in the instructions, and why we put care in transitioning from one section to the next is because it squashes excuses for the reader to stop reading, along with any unnecessary questions that pop up and might otherwise turn into burdensome support tickets.
LMK when we're good for another look, thanks!
984b0f5 to
3e53626
Compare
3e53626 to
151e7a0
Compare
|
@StraubCreative I've re-worked the document once more and I think you'll be pleased with the results. I've added more detail and direction for the layman. I believe this is ready to merge. Thanks for your previous reviews and I look forward to seeing this doc published. Thanks, Tim |
|
@fw-bot ignore |
|
Forward-port disabled. |
| --------------------- | ||
|
|
||
| To sign in to Odoo for the first time using the Microsoft Azure OAuth provider, navigate to the Odoo | ||
| database login page (using the invitation link) and click on the option labeled :guilabel:`Microsoft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we just say /web?
| database login page (using the invitation link) and click on the option labeled :guilabel:`Microsoft | |
| database login page (using the invitation link) and click on the option labeled :guilabel:`Microsoft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a specific flow that the user needs to follow. They should be in the "password set" phase for the Odoo user. I don't think saying web here will be helpful, but I'm open to ideas. Can you specify where 'web' should be inserted?
ca4bdbf to
05e0523
Compare
|
@StraubCreative I've made all the requested changes and pushed up to GH using the batch process, so you're a collaborator on this PR. I made one small comment on line 152. This is about ready to be merged. |
05e0523 to
f270acf
Compare
|
@StraubCreative -- I've made the changes we talked about offline. I believe this doc is ready to ship. For your reference, I edited lines 150-165. Feel free to push any grammar/technical edits you see fit. Thanks for your help on this PR! Have a nice vacay! 👍 |
closes #5041 Signed-off-by: Zachary Straub (zst) <zst@odoo.com> Co-authored-by: Zachary Straub <zst@odoo.com>
R&D Task: https://www.odoo.com/web#id=2854287&cids=3&model=project.task&view_type=form
Documentation task: https://www.odoo.com/web#model=project.task&id=3395014&active_id=3395014&cids=3