Skip to content

Conversation

@tiku-odoo
Copy link
Contributor

@robodoo
Copy link
Collaborator

robodoo commented Jul 6, 2023

@tiku-odoo
Copy link
Contributor Author

@bouvyd

Can you take a quick look at this process as I documented it? I'm missing something as the login is being denied.

Thanks,
Tim

@tiku-odoo tiku-odoo self-assigned this Jul 6, 2023
@tiku-odoo tiku-odoo requested a review from bouvyd July 6, 2023 18:00
@C3POdoo C3POdoo requested a review from a team July 6, 2023 18:00
@tiku-odoo tiku-odoo added the priority Priority lane PRs directly from POs label Jul 10, 2023
@tiku-odoo tiku-odoo force-pushed the 14.0-Misc-Login-Azure-Oauth-tiku branch from ddbe7cd to 8576c72 Compare July 13, 2023 19:37
@tiku-odoo tiku-odoo requested review from StraubCreative and removed request for bouvyd July 13, 2023 19:44
@tiku-odoo
Copy link
Contributor Author

@StraubCreative This PR is ready for your review. It is a priority PR from the PO. Thanks.
Tim

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tiku-odoo
Please double-check the whole doc for grammar, 100th char line breaks, and thoroughness in the instructions. I highlighted a few examples below, thanks!

@tiku-odoo tiku-odoo force-pushed the 14.0-Misc-Login-Azure-Oauth-tiku branch from 8576c72 to c739272 Compare July 14, 2023 16:02
@tiku-odoo
Copy link
Contributor Author

@StraubCreative I've re-read the doc for grammar, 100-character line breaks, and thoroughness of instructions. Thank you for your suggestions. I'm really looking forward to pushing this live. Thanks for your additional review! 👍

@tiku-odoo tiku-odoo requested review from a team and StraubCreative July 14, 2023 16:05
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tiku-odoo

Try again please.

I'm looking for thoroughness, guided transitions, and specificity in language.

  • Label what things are, consistently.
  • Guide people, thoroughly, in each instruction and when transitioning to new sections.
  • Be exhaustive.

I've labeled a few spots below, but not all.

I want to be able to look at this doc and know exactly what to do, what things are, where they're located, and how all of those things work, even if I know nothing and can't look at screenshots.

The reason we're specific, why we take the time to be thorough in the instructions, and why we put care in transitioning from one section to the next is because it squashes excuses for the reader to stop reading, along with any unnecessary questions that pop up and might otherwise turn into burdensome support tickets.

LMK when we're good for another look, thanks!

@tiku-odoo tiku-odoo force-pushed the 14.0-Misc-Login-Azure-Oauth-tiku branch 2 times, most recently from 984b0f5 to 3e53626 Compare July 19, 2023 14:09
@tiku-odoo tiku-odoo changed the title [IMP] Misc: Login-Oauth-Azure-Edits [IMP] Misc: Login Oauth Azure Edits Jul 19, 2023
@tiku-odoo tiku-odoo force-pushed the 14.0-Misc-Login-Azure-Oauth-tiku branch from 3e53626 to 151e7a0 Compare July 19, 2023 17:28
@tiku-odoo tiku-odoo requested a review from StraubCreative July 19, 2023 17:28
@tiku-odoo
Copy link
Contributor Author

@StraubCreative I've re-worked the document once more and I think you'll be pleased with the results. I've added more detail and direction for the layman. I believe this is ready to merge. Thanks for your previous reviews and I look forward to seeing this doc published.

Thanks, Tim

@StraubCreative
Copy link
Contributor

@fw-bot ignore

@fw-bot
Copy link
Collaborator

fw-bot commented Jul 19, 2023

Forward-port disabled.

---------------------

To sign in to Odoo for the first time using the Microsoft Azure OAuth provider, navigate to the Odoo
database login page (using the invitation link) and click on the option labeled :guilabel:`Microsoft
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we just say /web?

Suggested change
database login page (using the invitation link) and click on the option labeled :guilabel:`Microsoft
database login page (using the invitation link) and click on the option labeled :guilabel:`Microsoft

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a specific flow that the user needs to follow. They should be in the "password set" phase for the Odoo user. I don't think saying web here will be helpful, but I'm open to ideas. Can you specify where 'web' should be inserted?

@tiku-odoo tiku-odoo force-pushed the 14.0-Misc-Login-Azure-Oauth-tiku branch 2 times, most recently from ca4bdbf to 05e0523 Compare July 20, 2023 14:30
@tiku-odoo
Copy link
Contributor Author

@StraubCreative
Thanks for your thorough review!

I've made all the requested changes and pushed up to GH using the batch process, so you're a collaborator on this PR.

I made one small comment on line 152. This is about ready to be merged.

@tiku-odoo tiku-odoo force-pushed the 14.0-Misc-Login-Azure-Oauth-tiku branch from 05e0523 to f270acf Compare July 21, 2023 16:31
@tiku-odoo
Copy link
Contributor Author

@StraubCreative -- I've made the changes we talked about offline. I believe this doc is ready to ship. For your reference, I edited lines 150-165. Feel free to push any grammar/technical edits you see fit.

Thanks for your help on this PR!

Have a nice vacay! 👍

StraubCreative added a commit that referenced this pull request Aug 2, 2023
closes #5041

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 2, 2023
closes #5041

closes #5248

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
fw-bot pushed a commit that referenced this pull request Aug 2, 2023
closes #5041

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
X-original-commit: 66b2a3d
Co-authored-by: Zachary Straub <zst@odoo.com>
fw-bot pushed a commit that referenced this pull request Aug 2, 2023
closes #5041

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
X-original-commit: 66b2a3d
Co-authored-by: Zachary Straub <zst@odoo.com>
fw-bot pushed a commit that referenced this pull request Aug 2, 2023
closes #5041

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
X-original-commit: 66b2a3d
Co-authored-by: Zachary Straub <zst@odoo.com>
fw-bot pushed a commit that referenced this pull request Aug 2, 2023
closes #5041

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
X-original-commit: 66b2a3d
Co-authored-by: Zachary Straub <zst@odoo.com>
fw-bot pushed a commit that referenced this pull request Aug 2, 2023
closes #5041

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
X-original-commit: 66b2a3d
Co-authored-by: Zachary Straub <zst@odoo.com>
fw-bot pushed a commit that referenced this pull request Aug 2, 2023
closes #5041

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
X-original-commit: 66b2a3d
Co-authored-by: Zachary Straub <zst@odoo.com>
fw-bot pushed a commit that referenced this pull request Aug 2, 2023
closes #5041

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
X-original-commit: 66b2a3d
Co-authored-by: Zachary Straub <zst@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 2, 2023
closes #5041

closes #5253

X-original-commit: 66b2a3d
Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 2, 2023
closes #5041

closes #5252

X-original-commit: 66b2a3d
Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 2, 2023
closes #5041

closes #5251

X-original-commit: 66b2a3d
Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 2, 2023
closes #5041

closes #5250

X-original-commit: 66b2a3d
Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 2, 2023
closes #5041

closes #5249

X-original-commit: 66b2a3d
Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 2, 2023
closes #5041

closes #5255

X-original-commit: 66b2a3d
Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 3, 2023
closes #5041

closes #5254

X-original-commit: 66b2a3d
Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

14.0 priority Priority lane PRs directly from POs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants