Skip to content

[FIX] developer/tutorials/discover_js_framework: add missing this #5677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FIX] developer/tutorials/discover_js_framework: add missing this #5677

wants to merge 1 commit into from

Conversation

@tax25
Copy link
Contributor

@tax25 tax25 commented Aug 30, 2023 •
edited by AntoineVDV
Loading

No description provided.

@tax25
Update 01_owl_components.rst - added 'this' in line 49
5a652aa 
Added 'this' to 'this.state = useState({ value: 0 });'.
@robodoo
Copy link
Collaborator

robodoo commented Aug 30, 2023

Pull request status dashboard.

@C3POdoo C3POdoo requested a review from a team August 30, 2023 08:34
@sdegueldre sdegueldre requested a review from a team August 30, 2023 10:48
AntoineVDV
AntoineVDV approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution :)

@robodoo r+ squash

@AntoineVDV AntoineVDV changed the title [FIX] Added 'this.' to 01_owl_components.rst:49 [FIX] developer/tutorials/discover_js_framework: add missing this Aug 30, 2023
@robodoo
Copy link
Collaborator

robodoo commented Aug 30, 2023

Merge method set to squash.

@robodoo robodoo closed this in 44ef78b Aug 30, 2023
@robodoo robodoo temporarily deployed to merge August 30, 2023 13:10 Inactive
This was referenced Aug 30, 2023
Closed
Closed
Closed
Closed
Closed
robodoo pushed a commit that referenced this pull request Aug 30, 2023
@tax25
[FW][FIX] developer/tutorials/discover_js_framework: add missing this
a05f07d 
closes #5679

Forward-port-of: #5677
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 30, 2023
@tax25
[FW][FIX] developer/tutorials/discover_js_framework: add missing this
5722492 
closes #5681

Forward-port-of: #5677
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 30, 2023
@tax25
[FW][FIX] developer/tutorials/discover_js_framework: add missing this
be308df 
closes #5685

Forward-port-of: #5677
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 30, 2023
@tax25
[FW][FIX] developer/tutorials/discover_js_framework: add missing this
4854470 
closes #5683

Forward-port-of: #5677
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 30, 2023
@tax25
[FW][FIX] developer/tutorials/discover_js_framework: add missing this
5769d31 
closes #5685

Forward-port-of: #5677
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 31, 2023
@tax25
[FW][FIX] developer/tutorials/discover_js_framework: add missing this
2907683 
closes #5683

Forward-port-of: #5677
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 31, 2023
@tax25
[FW][FIX] developer/tutorials/discover_js_framework: add missing this
2f9645c 
closes #5687

Forward-port-of: #5677
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AntoineVDV AntoineVDV AntoineVDV approved these changes

+1 more reviewer

@sdegueldre sdegueldre sdegueldre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tax25 @robodoo @AntoineVDV @sdegueldre