-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[FIX] developer/tutorials/discover_js_framework: fix broken "domain.js" link #5702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AntoineVDV
requested changes
Sep 1, 2023
AntoineVDV
approved these changes
Sep 1, 2023
Collaborator
AntoineVDV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+ squash
Collaborator
|
Merge method set to squash. |
This was referenced Sep 1, 2023
robodoo
added a commit
that referenced
this pull request
Sep 4, 2023
…in.js" link The link pointing to domain.js file was broken. The xml id on the line before that is also broken but it will be fixed with PR#5699. closes #5707 Forward-port-of: #5702 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Co-authored-by: Armin FalDiS <armin.fallah96@gmail.com> Co-authored-by: Armin FalDiS <fara@odoo.com>
robodoo
added a commit
that referenced
this pull request
Sep 4, 2023
…in.js" link The link pointing to domain.js file was broken. The xml id on the line before that is also broken but it will be fixed with PR#5699. closes #5706 Forward-port-of: #5702 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Co-authored-by: Armin FalDiS <armin.fallah96@gmail.com> Co-authored-by: Armin FalDiS <fara@odoo.com>
robodoo
added a commit
that referenced
this pull request
Sep 4, 2023
…in.js" link The link pointing to domain.js file was broken. The xml id on the line before that is also broken but it will be fixed with PR#5699. closes #5709 Forward-port-of: #5702 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Co-authored-by: Armin FalDiS <armin.fallah96@gmail.com> Co-authored-by: Armin FalDiS <fara@odoo.com>
robodoo
added a commit
that referenced
this pull request
Sep 4, 2023
…in.js" link The link pointing to domain.js file was broken. The xml id on the line before that is also broken but it will be fixed with PR#5699. closes #5705 Forward-port-of: #5702 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Co-authored-by: Armin FalDiS <armin.fallah96@gmail.com> Co-authored-by: Armin FalDiS <fara@odoo.com>
robodoo
added a commit
that referenced
this pull request
Sep 4, 2023
…in.js" link The link pointing to domain.js file was broken. The xml id on the line before that is also broken but it will be fixed with PR#5699. closes #5708 Forward-port-of: #5702 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Co-authored-by: Armin FalDiS <armin.fallah96@gmail.com> Co-authored-by: Armin FalDiS <fara@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link pointing to domain.js file was broken.
The xml id on the line before that is also broken but it will be fixed with PR#5699.