Skip to content

[IMP] crm: update plan activities #5941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] crm: update plan activities #5941

wants to merge 1 commit into from

Conversation

@jero-odoo
Copy link
Contributor

@jero-odoo jero-odoo commented Sep 28, 2023 •
edited
Loading

Updated for 15.0, including content and images.
Changed second-person to third-person
Added additional context for activity type configuration and scheduling.

@robodoo
Copy link
Collaborator

robodoo commented Sep 28, 2023

Pull request status dashboard.

@C3POdoo C3POdoo requested a review from a team September 28, 2023 20:05
@jero-odoo jero-odoo self-assigned this Sep 28, 2023
@jero-odoo jero-odoo force-pushed the 15.0-crm-planning-activities-jero branch from e1ef50a to f41a3b9 Compare September 29, 2023 18:54
@jero-odoo
Copy link
Contributor Author

jero-odoo commented Sep 29, 2023

@tiku-odoo Can you take a look at this? It falls under both CRM and Discuss. Thanks!

@tiku-odoo tiku-odoo self-requested a review October 5, 2023 17:24
tiku-odoo
tiku-odoo reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@tiku-odoo tiku-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jero-odoo Good start; I made some suggestions. Are you forward porting to 16? If so, I would add adaptive wording surrounding the "edit/save" buttons (if required/ if applicable).

Let me know when you make the changes, and I can take another look.

Thanks,
Tim 👍

@jero-odoo jero-odoo force-pushed the 15.0-crm-planning-activities-jero branch from f41a3b9 to 3fa0212 Compare October 19, 2023 19:32
@jero-odoo
Copy link
Contributor Author

jero-odoo commented Oct 19, 2023

Hi @tiku-odoo , Can you take another look at this one? I made some adjustments to make it more focused on activities in general, and less on the CRM. Once it is published, I will go back and create a CRM-specific doc focused on using activities to follow up on leads/opportunities. Let me know if you have any questions. Thank you!

@jero-odoo jero-odoo requested a review from tiku-odoo October 19, 2023 19:36
tiku-odoo
tiku-odoo approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@tiku-odoo tiku-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo,

Great job on the re-write of this doc. You streamlined it and made it to the point. Great flow.

I made a few comments. A couple alt tags missing on the images. Last image needs a lead-in.

Looking forward to seeing this published.

Tim 👍

@jero-odoo jero-odoo force-pushed the 15.0-crm-planning-activities-jero branch from 712df89 to fdda5cc Compare October 30, 2023 16:09
@jero-odoo
Copy link
Contributor Author

jero-odoo commented Oct 30, 2023

@odoo/crm-doc-review Can you take a look at this for the second round? As I said above, it originally started as a CRM document, but I adjusted it to be more general to all uses of Activities. Let me know if you have any questions. Thanks!

@jero-odoo jero-odoo requested a review from a team October 30, 2023 16:13
ksc-odoo
ksc-odoo reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jero-odoo -- great work on this doc! Just had some basic feedback for ya to take a look at, but once those suggestions are addressed, I think this one will be ready for the next stage! Awesome job! 👍

@jero-odoo jero-odoo force-pushed the 15.0-crm-planning-activities-jero branch from af58f17 to 5cdb135 Compare November 14, 2023 16:59
@jero-odoo
Copy link
Contributor Author

jero-odoo commented Nov 14, 2023

Thank you @ksc-odoo can you give this one another look to approve the changes? Thanks!

@jero-odoo jero-odoo requested a review from ksc-odoo November 14, 2023 17:00
ksc-odoo
ksc-odoo approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jero-odoo Great Work on this doc. Only had a handful of minor suggestions that you may want to consider before passing this on to the next stage. but, other than that -- nice job! 👍

@jero-odoo jero-odoo force-pushed the 15.0-crm-planning-activities-jero branch from e04bec9 to 910df32 Compare November 27, 2023 14:50
@jero-odoo
Copy link
Contributor Author

jero-odoo commented Nov 27, 2023

Thank you @ksc-odoo ! Ready for @odoo/us-doc-review !

@jero-odoo jero-odoo requested a review from a team November 27, 2023 14:51
samueljlieber
samueljlieber requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo! Nice job with this doc, I think you covered Activities very well 👍. I have a few technical corrections, please see below and also let me know your thoughts on the figure formatting! Then please tag me for another look once this PR is ready 🙂

@jero-odoo jero-odoo force-pushed the 15.0-crm-planning-activities-jero branch 2 times, most recently from a7b9895 to 60bce10 Compare November 27, 2023 21:32
@jero-odoo
Copy link
Contributor Author

jero-odoo commented Nov 27, 2023

Updated @samueljlieber , can you take another look when you get a chance? Thanks!

StraubCreative
StraubCreative requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo
Few change requests below.
The only necessary one is to fix the double-colon on a gui.
Everything else is optional 😉

Please tag me again for merge when you're finished making changes, thanks!

@jero-odoo jero-odoo force-pushed the 15.0-crm-planning-activities-jero branch from 59cb93e to 8055bb2 Compare December 4, 2023 15:33
@jero-odoo
Copy link
Contributor Author

jero-odoo commented Dec 4, 2023

Hey @StraubCreative can you take another look? Thanks!

@StraubCreative
Copy link
Contributor

StraubCreative commented Dec 4, 2023

@robodoo delegate=samueljlieber

samueljlieber
samueljlieber approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo! I am approving and moving this PR forward for merge. I found one small fix which I will push up now. Thank you and nice work!

content/applications/productivity/discuss/overview/plan_activities.rst Outdated
Comment on lines 101 to 103
- Activities that appear in **green** indicate a due date sometime in the future.
- **Yellow** indicates that the activity's due date is today.
- **Red** indicates that the activity is overdue and the due date has passed.
Copy link
Contributor

@samueljlieber samueljlieber Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small indentation fix

Suggested change
- Activities that appear in **green** indicate a due date sometime in the future.
- **Yellow** indicates that the activity's due date is today.
- **Red** indicates that the activity is overdue and the due date has passed.
- Activities that appear in **green** indicate a due date sometime in the future.
- **Yellow** indicates that the activity's due date is today.
- **Red** indicates that the activity is overdue and the due date has passed.

@jero-odoo @tiku-odoo
@ksc-odoo @samueljlieber @StraubCreative
[IMP] crm: update plan activities
b653d50 
Co-authored-by: Timothy Kukulka <91896312+tiku-odoo@users.noreply.github.com>
Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
@samueljlieber samueljlieber force-pushed the 15.0-crm-planning-activities-jero branch from 8055bb2 to b653d50 Compare December 5, 2023 15:17
@samueljlieber
Copy link
Contributor

samueljlieber commented Dec 5, 2023

@robodoo r+

robodoo pushed a commit that referenced this pull request Dec 5, 2023
@jero-odoo @tiku-odoo
@ksc-odoo @samueljlieber @StraubCreative
[IMP] crm: update plan activities
e4aee35 
closes #5941

Signed-off-by: Samuel Lieber (sali) <sali@odoo.com>
Co-authored-by: Timothy Kukulka <91896312+tiku-odoo@users.noreply.github.com>
Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
@fw-bot fw-bot mentioned this pull request Dec 5, 2023
Closed
@robodoo robodoo closed this Dec 5, 2023
This was referenced Dec 5, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@MaxKeilOdoo MaxKeilOdoo mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueljlieber samueljlieber samueljlieber approved these changes

@StraubCreative StraubCreative Awaiting requested review from StraubCreative

+2 more reviewers

@ksc-odoo ksc-odoo ksc-odoo approved these changes

@tiku-odoo tiku-odoo tiku-odoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jero-odoo jero-odoo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jero-odoo @robodoo @StraubCreative @samueljlieber @ksc-odoo @tiku-odoo