Skip to content

Conversation

@larm-odoo
Copy link
Contributor

New document explaining all of Referrals. Will be forward ported to 16, then 17 when that is live, and targeted edits will be made for those versions.

@robodoo
Copy link
Collaborator

robodoo commented Oct 23, 2023

@C3POdoo C3POdoo requested review from a team October 23, 2023 19:03
@larm-odoo larm-odoo force-pushed the 15.0-Referrals-new-how-to-in-depth-doc-larm branch from 28d34bd to cd9e30f Compare October 23, 2023 19:17
@larm-odoo larm-odoo requested a review from jero-odoo October 24, 2023 14:41
Copy link
Contributor

@jero-odoo jero-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @larm-odoo nice work. I had some suggestions, mostly on formatting and organization. Let me know if you have any questions. Thanks

@larm-odoo larm-odoo force-pushed the 15.0-Referrals-new-how-to-in-depth-doc-larm branch from cd9e30f to 0593649 Compare October 30, 2023 19:48
@larm-odoo larm-odoo requested a review from jero-odoo October 30, 2023 19:48
@larm-odoo
Copy link
Contributor Author

Thanks @jero-odoo! All comments either accepted/added to the doc or explained (not many I didn't take). I tagged you again for another look and an approval. Thanks in advance!

Copy link
Contributor

@jero-odoo jero-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @larm-odoo just a few changes (mostly grammar and spelling). Good to go otherwise 👍

@larm-odoo larm-odoo force-pushed the 15.0-Referrals-new-how-to-in-depth-doc-larm branch from 0593649 to 7b9b4c3 Compare November 1, 2023 20:16
@larm-odoo larm-odoo requested a review from tiku-odoo November 1, 2023 20:16
@larm-odoo
Copy link
Contributor Author

larm-odoo commented Nov 1, 2023

Hi @tiku-odoo - this is ready for you! There is a doc link in here that links to a recruitment doc that is NOT published yet- so that error is visible, be aware. It will not appear once that is published. Also you can disregard any errors from 'code owner' per Sam.

Copy link
Contributor

@tiku-odoo tiku-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larm-odoo

Awesome job on this doc, really great flows and explanations.

I still have some more to go on this doc and I didn't want to rush through it as I've left a few functional edit suggestions above that I don't want to miss any below. Hold off on making any edits until I can finish out the doc.
Thanks and great work on this doc! Have a nice weekend

Copy link
Contributor

@tiku-odoo tiku-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larm-odoo

Nice work on the document. I made a few comments and it's ready for your review.

I noticed that you didn't cover friends in this document, configuration--> Friends

I would also like to know the level of access needed to make the various edits you review in the doc (as it is mixed throughout the doc)

Looking forward to seeing this published!

@larm-odoo larm-odoo requested a review from a team November 7, 2023 21:12
@larm-odoo
Copy link
Contributor Author

Thank you @tiku-odoo! I incorporated your edits - thanks for finding some things I didn't catch!

All set for you, @odoo/us-doc-review! Please note, the error for the document 'recruitment' is currently on #5994 - this referrals document must be published after the recruitment doc, so the link works.

@larm-odoo larm-odoo force-pushed the 15.0-Referrals-new-how-to-in-depth-doc-larm branch from 7b9b4c3 to 32abdc0 Compare November 7, 2023 21:23
@Xavier-Do Xavier-Do removed the request for review from a team November 8, 2023 09:12
@C3POdoo C3POdoo requested a review from a team November 8, 2023 09:21
@larm-odoo larm-odoo force-pushed the 15.0-Referrals-new-how-to-in-depth-doc-larm branch from 32abdc0 to cbee644 Compare November 9, 2023 21:17
@C3POdoo C3POdoo requested a review from a team November 9, 2023 21:18
- :guilabel:`Contract Signed`: 50 points

The total points earned for a referral that is hired is 85 points. Modifications of the points
earned for each stage is done in the Recruitment application. Refer to the :doc:`../recruitment`
Copy link
Contributor

@samueljlieber samueljlieber Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @larm-odoo, I am commenting on this line (552) regarding the ../recruitment build error, can you please fix this before I review?

Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fixed @samueljlieber! The link currently sends you to a doc that is being updated on #5994. So when you click it, you see this page: https://www.odoo.com/documentation/17.0/applications/hr/recruitment.html
Currently, this is mostly blank, and just has a link to the Job Positions doc. But PR #5994 is the detailed Hiring Flow doc, which is what this will be pointing to, ultimately.

@larm-odoo larm-odoo force-pushed the 15.0-Referrals-new-how-to-in-depth-doc-larm branch from cbee644 to 0ae0ade Compare November 27, 2023 18:57
@Felicious Felicious removed the request for review from a team December 13, 2023 22:47
@samueljlieber samueljlieber force-pushed the 15.0-Referrals-new-how-to-in-depth-doc-larm branch from 0ae0ade to 4e469a2 Compare December 21, 2023 15:46
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @larm-odoo! This PR looks good to me. I just pushed up a commit updating the :ref: on line 552 to point to the correct section in recruitment.rst that will be added in #5994.

@StraubCreative this PR is good to go, but needs to be merged AFTER #5994 👍

@StraubCreative
Copy link
Contributor

@samueljlieber #5994 has been merged along with it's forward-port chain, just now, on #7099

Can merge here after rebase and CI checks pass, thanks!

@robodoo delegate=samueljlieber

@samueljlieber samueljlieber force-pushed the 15.0-Referrals-new-how-to-in-depth-doc-larm branch from 4e469a2 to 8ba5f1a Compare December 26, 2023 14:46
@samueljlieber
Copy link
Contributor

Rebased to fix CI check error, I will push up one more commit to fix a few items in the referrals.rst doc I caught while reviewing.

@samueljlieber samueljlieber force-pushed the 15.0-Referrals-new-how-to-in-depth-doc-larm branch from 8ba5f1a to 09d3e39 Compare December 26, 2023 15:19
@samueljlieber
Copy link
Contributor

Updated an emoji on line 367 that was not loading and updated to guilabels on lines 37-41 in 09d3e39

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants