-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[ADD] Upgrade documentation for developers #6757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a61604f to
215f202
Compare
90e5b80 to
638db63
Compare
dd0b1b6 to
2717665
Compare
2717665 to
0fde9ae
Compare
|
Hi there, I see that the PR is still a work in progress (TODOs in the content, "Temporary PR" in the description, recent pushes...) but it was made ready for review; was it intended? |
|
Hello @AntoineVDV , we might have put it a few hours too early for review but it's ready now |
fc54d8c to
7e73af6
Compare
nmarotte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey :D Quickly glanced over and noticed a few things that you might want to check :)
fb320bd to
52f4ca5
Compare
AntoineVDV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, interesting doc 🙂
I put my review comments for the /developer part of the diff below. None of them are really blocking, so feel free to apply or discard.
Also,
- The previous rewrite of the upgrade documentation targeted 16.0. Wouldn't it make sense to target the same branch with this PR so that partners browsing the documentation in 16.0 can find the How-to guide too?
- I added a codeowner rule for the new file so the
ci/codeowner_coverageshould be green, but you must also fix whatever is making theci/documentation_guidelinesred.
|
Hello @AntoineVDV Thank you so much for your comments and inputs, I applied most of them (and set them as resolved). As requested, the Regarding the taget version, this documentation is a general approach to Upgrade custom databases, it is independent from a specific Odoo version. The same applies to the previous PR: #6274 |
af09123 to
9ab939b
Compare
|
In general, version-independent documentation PRs should target the lowest supported branch (15.0 here). Since the previous PR targeted 16.0, I recommend targeting 16.0 too and, in less than one year, 15.0 will be deprecated anyway. The reason is that users accessing the documentation from their Odoo database will be redirected to the version of the documentation that matches the version of their database. |
2d381ba to
e6a17c0
Compare
AntoineVDV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just squash the commits and we're good to go.
e6a17c0 to
ab15cfe
Compare
|
@AntoineVDV commits squashed 😉 |
|
@robodoo r+ |
closes #6757 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
More and more demand came from partners to have information about the upgrade process.
In this page, we intend to introduce the process we've been following at PS-tech for several year.
In the future there will be multiple pages around this one giving explanation on upgrade related topics.