Skip to content

Conversation

@hepi-nandoo
Copy link

@hepi-nandoo hepi-nandoo commented Dec 5, 2023

More and more demand came from partners to have information about the upgrade process.
In this page, we intend to introduce the process we've been following at PS-tech for several year.
In the future there will be multiple pages around this one giving explanation on upgrade related topics.

@robodoo
Copy link
Collaborator

robodoo commented Dec 5, 2023

@hepi-nandoo hepi-nandoo force-pushed the 17.0-upgrade-3171474-hepi branch from a61604f to 215f202 Compare December 5, 2023 10:34
@hepi-nandoo hepi-nandoo marked this pull request as draft December 5, 2023 10:35
@augustoPerez augustoPerez force-pushed the 17.0-upgrade-3171474-hepi branch from 90e5b80 to 638db63 Compare December 21, 2023 09:24
@hepi-nandoo hepi-nandoo marked this pull request as ready for review January 4, 2024 14:03
@augustoPerez augustoPerez force-pushed the 17.0-upgrade-3171474-hepi branch from dd0b1b6 to 2717665 Compare January 4, 2024 14:08
@hepi-nandoo hepi-nandoo requested a review from xpl-odoo January 4, 2024 14:09
@C3POdoo C3POdoo requested review from a team January 4, 2024 14:18
@augustoPerez augustoPerez force-pushed the 17.0-upgrade-3171474-hepi branch from 2717665 to 0fde9ae Compare January 4, 2024 14:22
@AntoineVDV
Copy link
Collaborator

AntoineVDV commented Jan 4, 2024

Hi there, I see that the PR is still a work in progress (TODOs in the content, "Temporary PR" in the description, recent pushes...) but it was made ready for review; was it intended?

@hepi-nandoo hepi-nandoo changed the title 17.0 upgrade 3171474 hepi [ADD] Upgrade documentation for developers Jan 5, 2024
@hepi-nandoo
Copy link
Author

Hello @AntoineVDV , we might have put it a few hours too early for review but it's ready now

@augustoPerez augustoPerez force-pushed the 17.0-upgrade-3171474-hepi branch from fc54d8c to 7e73af6 Compare January 5, 2024 08:39
Copy link
Contributor

@nmarotte nmarotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey :D Quickly glanced over and noticed a few things that you might want to check :)

@augustoPerez augustoPerez force-pushed the 17.0-upgrade-3171474-hepi branch 2 times, most recently from fb320bd to 52f4ca5 Compare January 5, 2024 10:37
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, interesting doc 🙂

I put my review comments for the /developer part of the diff below. None of them are really blocking, so feel free to apply or discard.

Also,

  • The previous rewrite of the upgrade documentation targeted 16.0. Wouldn't it make sense to target the same branch with this PR so that partners browsing the documentation in 16.0 can find the How-to guide too?
  • I added a codeowner rule for the new file so the ci/codeowner_coverage should be green, but you must also fix whatever is making the ci/documentation_guidelines red.

@augustoPerez
Copy link
Contributor

Hello @AntoineVDV

Thank you so much for your comments and inputs, I applied most of them (and set them as resolved).
I will continue with the remaining ones tomorrow.

As requested, the ci checks have been checked and all of them are green.

Regarding the taget version, this documentation is a general approach to Upgrade custom databases, it is independent from a specific Odoo version. The same applies to the previous PR: #6274
Does it make a difference the version that is targeted?
We chose 16.0 for the previous PR because Odoo 17 was not out yet.

@augustoPerez augustoPerez force-pushed the 17.0-upgrade-3171474-hepi branch from af09123 to 9ab939b Compare January 10, 2024 08:29
@AntoineVDV
Copy link
Collaborator

AntoineVDV commented Jan 10, 2024

In general, version-independent documentation PRs should target the lowest supported branch (15.0 here). Since the previous PR targeted 16.0, I recommend targeting 16.0 too and, in less than one year, 15.0 will be deprecated anyway. The reason is that users accessing the documentation from their Odoo database will be redirected to the version of the documentation that matches the version of their database.

@AntoineVDV AntoineVDV marked this pull request as draft January 10, 2024 14:03
@AntoineVDV AntoineVDV changed the base branch from 17.0 to 16.0 January 10, 2024 14:03
@augustoPerez augustoPerez force-pushed the 17.0-upgrade-3171474-hepi branch from 2d381ba to e6a17c0 Compare January 10, 2024 14:14
@augustoPerez augustoPerez marked this pull request as ready for review January 10, 2024 14:15
@C3POdoo C3POdoo requested a review from a team January 10, 2024 14:19
@AntoineVDV AntoineVDV removed the request for review from a team January 10, 2024 15:22
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just squash the commits and we're good to go.

@augustoPerez augustoPerez force-pushed the 17.0-upgrade-3171474-hepi branch from e6a17c0 to ab15cfe Compare January 10, 2024 16:18
@augustoPerez
Copy link
Contributor

@AntoineVDV commits squashed 😉

@AntoineVDV
Copy link
Collaborator

@robodoo r+

robodoo pushed a commit that referenced this pull request Jan 10, 2024
closes #6757

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
@robodoo robodoo closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants