Skip to content

[IMP] barcode: update adjustments doc #6889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] barcode: update adjustments doc #6889

wants to merge 1 commit into from

Conversation

@brse-odoo
Copy link
Contributor

@brse-odoo brse-odoo commented Dec 11, 2023

This PR is an [IMP] targeting the adjustments doc in Odoo's Inventory/Barcode documentation.

Performed complete rewrite to the document for 15.0 to be fwd-ported (targeted revision for 16.0/17.0 to follow).

  • Completely rewrote the .rst file
  • Replaced/added screenshots where appropriate
  • Rewrote and added to doc to make more robust and comprehensive than before

@brse-odoo brse-odoo self-assigned this Dec 11, 2023
@robodoo
Copy link
Collaborator

robodoo commented Dec 11, 2023

Pull request status dashboard.

@C3POdoo C3POdoo requested a review from a team December 11, 2023 16:12
@brse-odoo
Copy link
Contributor Author

brse-odoo commented Dec 11, 2023

@odoo/inventory-doc-review This PR is ready for the first round of peer review!

Felicious
Felicious requested changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brse-odoo !

Great job on this doc! It has improved a lot from the previous version, and I liked how easy it was to follow. It has a good mix of admonition blocks and images, so it was engaging and fun to read 😄

I just pointing a few formatting things I noticed, as well as some additional info to include. Let me know when you're done reviewing my comments, and I'll make a second, approving review!

@brse-odoo brse-odoo force-pushed the 15.0-barcode-update-inv-adj-brse branch from cb0243c to c55768b Compare December 21, 2023 15:24
@brse-odoo
Copy link
Contributor Author

brse-odoo commented Dec 21, 2023

@odoo/crm-doc-review This PR has passed the first round of content review, and is now ready for the second. Thanks in advance!

@brse-odoo brse-odoo requested a review from a team December 21, 2023 15:30
ksc-odoo
ksc-odoo approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this doc @brse-odoo ! Just finished my review. Only had a couple of minor suggestions that require your attention. But, once those are addressed, I believe this one will be ready for the next stage. Once again, awesome job! 👍

@brse-odoo brse-odoo force-pushed the 15.0-barcode-update-inv-adj-brse branch from c55768b to c270916 Compare December 28, 2023 15:31
@brse-odoo
Copy link
Contributor Author

brse-odoo commented Dec 28, 2023

@odoo/us-doc-review This PR has passed the first 2 rounds of content review, and is ready for final review. Thank you!

@brse-odoo brse-odoo requested a review from a team December 28, 2023 15:36
samueljlieber
samueljlieber requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brse-odoo 👋 nice job on the improvements in this PR! I only have a couple corrections, please see below. I will push up these changes just after the review to move this PR along, thank you!

content/applications/inventory_and_mrp/inventory/barcode/operations/adjustments.rst Outdated
Comment on lines 45 to 47
barcode scanner </applications/inventory_and_mrp/inventory/barcode/setup/hardware>` and
:doc:`Activate the Barcodes in Odoo
</applications/inventory_and_mrp/inventory/barcode/setup/software>` documentation pages.
Copy link
Contributor

@samueljlieber samueljlieber Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to relative doc path

Suggested change
barcode scanner </applications/inventory_and_mrp/inventory/barcode/setup/hardware>` and
:doc:`Activate the Barcodes in Odoo
</applications/inventory_and_mrp/inventory/barcode/setup/software>` documentation pages.
barcode scanner <../setup/hardware>` and :doc:`Activate the Barcodes in Odoo
<../setup/software>`.

content/applications/inventory_and_mrp/inventory/barcode/operations/adjustments.rst Outdated
Comment on lines 55 to 56
Once inside the *Barcode* app, a :guilabel:`Barcode Scanning` screen displaying different
options is presented.
Copy link
Contributor

@samueljlieber samueljlieber Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early line break

Suggested change
Once inside the *Barcode* app, a :guilabel:`Barcode Scanning` screen displaying different
options is presented.
Once inside the *Barcode* app, a :guilabel:`Barcode Scanning` screen displaying different options is
presented.

...s/inventory_and_mrp/inventory/barcode/operations/adjustments/adjustments-barcode-scanner.png
Copy link
Contributor

@samueljlieber samueljlieber Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retake & re-compress to be a smaller file size

@samueljlieber samueljlieber force-pushed the 15.0-barcode-update-inv-adj-brse branch from c270916 to c9107aa Compare January 10, 2024 14:42
samueljlieber
samueljlieber approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented technical changes in c9107aa.

@StraubCreative this PR is good to go 👍

StraubCreative
StraubCreative requested changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brse-odoo
See comments below, thanks!

@brse-odoo brse-odoo force-pushed the 15.0-barcode-update-inv-adj-brse branch from c9107aa to dfd406b Compare January 11, 2024 15:48
@brse-odoo
Copy link
Contributor Author

brse-odoo commented Jan 11, 2024

Hi @brse-odoo See comments below, thanks!

@StraubCreative Made the suggested changes and pushed up the revised doc, good to go 👍

StraubCreative
StraubCreative approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @brse-odoo 👍
Thanks for the quick changes!

@robodoo r+

robodoo pushed a commit that referenced this pull request Jan 11, 2024
@brse-odoo
[IMP] barcode: update adjustments doc
7d56862 
closes #6889

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
@robodoo robodoo closed this Jan 11, 2024
This was referenced Jan 11, 2024
Closed
Closed
@fw-bot
Copy link
Collaborator

fw-bot commented Jan 15, 2024

@brse-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

1 similar comment
@fw-bot
Copy link
Collaborator

fw-bot commented Jan 16, 2024

@brse-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

This was referenced Jan 17, 2024
Closed
Closed
Closed
This was referenced Jan 17, 2024
Closed
Closed
Closed
Closed
@fw-bot
Copy link
Collaborator

fw-bot commented Jan 17, 2024

@brse-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Felicious Felicious Felicious requested changes

@StraubCreative StraubCreative StraubCreative approved these changes

@samueljlieber samueljlieber samueljlieber approved these changes

+1 more reviewer

@ksc-odoo ksc-odoo ksc-odoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@brse-odoo brse-odoo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@brse-odoo @robodoo @fw-bot @StraubCreative @Felicious @samueljlieber @ksc-odoo