[ADD] Time Off: Adding new doc #7301
Conversation
larm-odoo
force-pushed
the
15.0-Time-Off-new-doc-larm
branch
from
51d7cb2 to
1bbb9ef
Compare
|
Hi @jero-odoo - this is all ready for you! The codeowner issue in the checks is not a problem according to Sam, FYI, so you are all set to review. Thanks in advance! |
jero-odoo
left a comment
jero-odoo
left a comment
There was a problem hiding this comment.
Hey @larm-odoo nice work, let me know if you have any questions, and when it is ready for me to take another look 👍
larm-odoo
force-pushed
the
15.0-Time-Off-new-doc-larm
branch
from
1bbb9ef to
97af363
Compare
|
Thanks @jero-odoo - feedback implemented! I also added a small section called Timesheets under the New Time Off Type section since I got answers form Emilio on that between your review and now, FYI. Ready for another look! |
jero-odoo
left a comment
jero-odoo
left a comment
There was a problem hiding this comment.
Hey @larm-odoo just a few formatting changes, so I am sending through with approval. Let me know if you have any questions. Thanks!
larm-odoo
force-pushed
the
15.0-Time-Off-new-doc-larm
branch
from
97af363 to
4c7db3b
Compare
|
@larm-odoo Does this doc contain IoT info that needs to be reviewed? |
|
Hi @tiku-odoo - no, it does not. But Zach told me that my first round of peer reviewers was always Jess, and for the second round, since anyone can review my doc, he suggested I chose one of the following teams at random: CRM doc review, IOT doc review, and Manufacturing doc review. This way, I will get a random other writer who is not on HR to do a second review. So I have been going round-robin and selecting one of these teams for each of my docs 2nd round of peer reviews. I could also tag a specific writer, but I thought tagging a team was better, this way, whoever had free time to do a review could go ahead. instead of waiting for one person to have the time. Hope that clears that up! Feel free to do the second round review, or anyone else on the IOT doc team can! =) |
|
Please tag me directly as well - I will get to the doc quicker. I am a one-person team on multiple GIT teams. Thanks. You can see scope teams here: https://docs.google.com/spreadsheets/d/1JNlThtqn6SVr43SM1XCPFFxyXACI6DLOBkaLcgsFokU/edit#gid=0 |
larm-odoo
requested review from
a team and
tiku-odoo
and removed request for
a team
larm-odoo
force-pushed
the
15.0-Time-Off-new-doc-larm
branch
from
4c7db3b to
032ba96
Compare
samueljlieber
left a comment
samueljlieber
left a comment
There was a problem hiding this comment.
Hi @larm-odoo! This is a great PR! Very thorough 💪. I have a handful of corrections, suggestions, and a few nitpicks 😄, please see below.
Please tag me for another look once this PR is ready! Thank you!
There was a problem hiding this comment.
Hey there @larm-odoo -- Just finished my Final Review of this and I have to say...GREAT JOB on this super-detailed, incredibly informative doc. In addition to these comments that I left, I agree with the ones previously left by @samueljlieber , as well. I think if you avoid/break-up the "chunky" paragraphs, establish consistency of formatting throughout, and grab some new, super-sharp screenshots -- you should be good to go! Hopefully, with both of our reviews, you'll be able to make this doc stronger than ever. Once you make all the suggested changes, I believe this one will be ready for Tech Review. If you have any questions, or need clarification on anything, just let me know. But, seriously, fantastic job on this lengthy doc! You crushed it!!! 👍
larm-odoo
force-pushed
the
15.0-Time-Off-new-doc-larm
branch
from
032ba96 to
f03f18e
Compare
larm-odoo
force-pushed
the
15.0-Time-Off-new-doc-larm
branch
from
21d21ae to
ce15c93
Compare
|
Hi @samueljlieber - everything is updated! |
samueljlieber
left a comment
samueljlieber
left a comment
There was a problem hiding this comment.
Looks great @larm-odoo, thank you!
@robodoo r+
closes #7301 Signed-off-by: Samuel Lieber (sali) <sali@odoo.com>
|
@larm-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed): |
2 similar comments
|
@larm-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@larm-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed): |
8 participants
No documentation exists for Time Off. Forward port this to V 16 and 17, then targeted edits can be made.