-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[IMP] crm: update webpage visits #7578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ksc-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meng-odoo great job on this doc. very direct and easy-to-follow. just had a handful of comments that need your attention. But, once you address those, I think this one will be ready for a 2nd Round of Peer Review. Great work! 👍
4457cd9 to
e108421
Compare
|
Thanks for the review @ksc-odoo! I've incorporated your changes. Now tagging @odoo/inventory-doc-review for the next peer review :) |
Felicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concise and clear doc @meng-odoo! What a strong return to authoring documentation 😊
The navigational instructions are really easy to follow, and the locations of buttons and menus are clearly described, while the doc remains engaging to read. I just had some very minor wording suggestions, and the flow works as expected 😄
Feel free to move this doc onto the next stage after addressing the suggestions of your choosing!
e108421 to
e39bd5a
Compare
|
Thanks so much for the review @Felicious! Now tagging @ksc-odoo for final review :) |
ksc-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meng-odoo great work on this PR! I only have a few, super-minor adjustments that require your attention. But, seeing as how they're all "quick fixes," I'm going to go ahead and approve this right now 👍 Once you make those adjustments, feel free to tag this one for Tech Review. Thanks!
e39bd5a to
4d07bdd
Compare
|
Thanks again for the prompt review @ksc-odoo! This is now ready for technical review @samueljlieber :) |
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @meng-odoo, nice work on this PR! It is looking pretty good, I only have a few technical corrections, please see below.
Let me know once these edits have been made, and I will take another look. Thank you!
content/applications/sales/crm/track_leads/prospect_visits/page-views-smart-button.png
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/prospect_visits/link-tracker-page.png
Show resolved
Hide resolved
content/applications/sales/crm/track_leads/prospect_visits/link-tracker-stats.png
Show resolved
Hide resolved
4d07bdd to
01b134c
Compare
|
Hi @samueljlieber, I've incorporated your edits and this is ready for another look. Thanks :) |
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @meng-odoo, thank you! Nice job 🙂
@StraubCreative this PR is good to go 👍
01b134c to
ff3f079
Compare
|
Rebased to latest in ff3f079 |
|
@robodoo r+ |
Updated 6-year-old doc about tracking website visitors through the Website link tracker and contact form, and having that tracking info appear on the lead/opportunity