Skip to content

Conversation

@meng-odoo
Copy link
Contributor

Updated 6-year-old doc about tracking website visitors through the Website link tracker and contact form, and having that tracking info appear on the lead/opportunity

@robodoo
Copy link
Collaborator

robodoo commented Jan 29, 2024

@C3POdoo C3POdoo requested a review from a team January 29, 2024 19:31
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meng-odoo great job on this doc. very direct and easy-to-follow. just had a handful of comments that need your attention. But, once you address those, I think this one will be ready for a 2nd Round of Peer Review. Great work! 👍

@meng-odoo meng-odoo force-pushed the 17.0-crm-update-tracking-webpage-visits-meng branch from 4457cd9 to e108421 Compare February 9, 2024 01:04
@meng-odoo
Copy link
Contributor Author

Thanks for the review @ksc-odoo! I've incorporated your changes.

Now tagging @odoo/inventory-doc-review for the next peer review :)

@meng-odoo meng-odoo requested a review from a team February 9, 2024 01:05
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concise and clear doc @meng-odoo! What a strong return to authoring documentation 😊

The navigational instructions are really easy to follow, and the locations of buttons and menus are clearly described, while the doc remains engaging to read. I just had some very minor wording suggestions, and the flow works as expected 😄

Feel free to move this doc onto the next stage after addressing the suggestions of your choosing!

@meng-odoo meng-odoo force-pushed the 17.0-crm-update-tracking-webpage-visits-meng branch from e108421 to e39bd5a Compare February 9, 2024 21:51
@meng-odoo
Copy link
Contributor Author

Thanks so much for the review @Felicious!

Now tagging @ksc-odoo for final review :)

@meng-odoo meng-odoo requested a review from ksc-odoo February 9, 2024 21:53
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meng-odoo great work on this PR! I only have a few, super-minor adjustments that require your attention. But, seeing as how they're all "quick fixes," I'm going to go ahead and approve this right now 👍 Once you make those adjustments, feel free to tag this one for Tech Review. Thanks!

@meng-odoo meng-odoo force-pushed the 17.0-crm-update-tracking-webpage-visits-meng branch from e39bd5a to 4d07bdd Compare February 13, 2024 00:31
@meng-odoo
Copy link
Contributor Author

Thanks again for the prompt review @ksc-odoo!

This is now ready for technical review @samueljlieber :)

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @meng-odoo, nice work on this PR! It is looking pretty good, I only have a few technical corrections, please see below.

Let me know once these edits have been made, and I will take another look. Thank you!

@meng-odoo meng-odoo force-pushed the 17.0-crm-update-tracking-webpage-visits-meng branch from 4d07bdd to 01b134c Compare February 14, 2024 00:50
@meng-odoo
Copy link
Contributor Author

Hi @samueljlieber, I've incorporated your edits and this is ready for another look. Thanks :)

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @meng-odoo, thank you! Nice job 🙂

@StraubCreative this PR is good to go 👍

@samueljlieber samueljlieber force-pushed the 17.0-crm-update-tracking-webpage-visits-meng branch from 01b134c to ff3f079 Compare March 28, 2024 21:57
@samueljlieber
Copy link
Contributor

Rebased to latest in ff3f079

@samueljlieber
Copy link
Contributor

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants