[IMP] Attendances: updating images and formatting

[larm-odoo]

Updating to new formatting standards. Images have annotations that need to be removed, one image is extra/unnecessary.

[robodoo]

[jero-odoo]

Hey @larm-odoo looks good to me, just a couple of things to note.
There is another image on this doc that has not been updated but still has the red markups on it (we are trying to move away from marked up images)

Also you will want to assign this doc to yourself!

[larm-odoo]

Hi @jero-odoo - thanks for reminding me to assign myself- I hadn't done that for ANY of my PR's =D.
I also changed this to a draft when I realized I needed to recreate that image, but needed several hours os it looked like I worked a few hours, etc. So I changed it to a draft, but had already tagged you- so I apologize for that, that was all my fault! It was only that one image you called out that was holding this back from not being a draft. Thank you for bearing with me while my feet are getting re-wet as they say!

[larm-odoo]

Hi @samueljlieber - this is ready for a tech review. Thank you!

[Felicious]

LGTM @larm-odoo ! Remember to add the points to the Label section of the PR!

[Felicious]

I know we phased out the emojis, but looking at the HTML for the icon, the circle icon has no color ):

Are there workarounds for this @samueljlieber, or do you think we should just fly with the emojis?

[samueljlieber]

@Felicious @larm-odoo
I recommend we describe the color like so, formatting the :icon: as usual:

Suggested change

	of what application the user is in, a :guilabel:`🔴 (red circle)` or :guilabel:`🟢 (green circle)` is
	of what application the user is in, a :icon:`fa-circle` :guilabel:`(red circle)` or
	:icon:`fa-circle` :guilabel:`(green circle)` is

LMK your thoughts!

---

Coloring icons is possible, and we discussed it when first implementing icons here: #8469 (review)

We decided not to use colors in icons or text in favor of writing out the UI color changes.

For your reference, this is one way we could color icons in documentation. Notice in your screenshot the text-success class that follows the icon's class. This is one of the Bootstrap color classes. The following RST will not work without first modifying the :icon: role's definition.

of what application the user is in, a :icon:`fa-circle text-danger` :guilabel:`(red circle)` or
:icon:`fa-circle text-success` :guilabel:`(green circle)` is 

A larger discussion is needed around the standards/guidelines for icon colors and how we want to implement them in documentation :)

[larm-odoo]

These are both good and valid. I personally prefer the color only because the UI is colored, and seeing a black circle then describing it as 'red' or 'green' is not my favorite- but it IS consistent with how we do other icons. When I wrote this doc, I know this was discussed, and we had originally landed on the colored circle icons that were in here, and I left them in and did not update them since I thought it was an exception, since we hashed it out when this was created.

Since we have the colored dots available, I do like the second option @samueljlieber presented, but I will absolutely just use the black dot and describe it, if that's what we want to do, @Felicious. Not sure who to listen to here, so I will await a reply to this comment =D

[larm-odoo]

I JUST re-read this, and see that the colored dots are not visible unless we make some modifications. Since that's never a good ide-a I put in the black dots and the text descriptor. Sorry about the confusion!

[larm-odoo]

Hi @samueljlieber - I believe this is now yours! I re-read your comment regarding the dots (I did leave those in on purpose, because I thought it was an exception since it was hashed out a while ago). I changed them so they are both just black dots with descriptions.

[samueljlieber]

Hi @larm-odoo, thank you for your work on this PR! Approving with a few comments, please update all emojis to icons in this doc before merging.

Thank you!
..
@robodoo delegate=larm-odoo

[larm-odoo]

@robodoo r+