[PERF] evaluation: stop the dependencies search early

From 40s to ~7s

closes #7308

Task: 4954710
X-original-commit: af36b26
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>

Author: LucasLefevre

src/plugins/ui_core_views/cell_evaluation/evaluator.ts

@@ -410,7 +410,8 @@ export class Evaluator {
   private invalidatePositionsDependingOnSpread(sheetId: UID, resultZone: Zone) {
     // the result matrix is split in 2 zones to exclude the array formula position
     const invalidatedPositions = this.formulaDependencies().getCellsDependingOn(
-      excludeTopLeft(resultZone).map((zone) => ({ sheetId, zone }))
+      excludeTopLeft(resultZone).map((zone) => ({ sheetId, zone })),
+      this.nextPositionsToUpdate
     );
     invalidatedPositions.delete({ sheetId, col: resultZone.left, row: resultZone.top });
     this.nextPositionsToUpdate.addMany(invalidatedPositions);
@@ -571,7 +572,7 @@ export class Evaluator {
     for (const sheetId in zonesBySheetIds) {
       ranges.push(...zonesBySheetIds[sheetId].map((zone) => ({ sheetId, zone })));
     }
-    return this.formulaDependencies().getCellsDependingOn(ranges);
+    return this.formulaDependencies().getCellsDependingOn(ranges, this.nextPositionsToUpdate);
   }
 }
 

src/plugins/ui_core_views/cell_evaluation/formula_dependency_graph.ts

@@ -58,7 +58,7 @@ export class FormulaDependencyGraph {
    * in the correct order they should be evaluated.
    * This is called a topological ordering (excluding cycles)
    */
-  getCellsDependingOn(ranges: RTreeBoundingBox[]): PositionSet {
+  getCellsDependingOn(ranges: RTreeBoundingBox[], ignore: PositionSet): PositionSet {
     const visited = this.createEmptyPositionSet();
     const queue: RTreeBoundingBox[] = Array.from(ranges).reverse();
     while (queue.length > 0) {
@@ -74,7 +74,7 @@ export class FormulaDependencyGraph {
       const impactedPositions = this.rTree.search(range).map((dep) => dep.data);
       const nextInQueue: Record<UID, Zone[]> = {};
       for (const position of impactedPositions) {
-        if (!visited.has(position)) {
+        if (!visited.has(position) && !ignore.has(position)) {
           if (!nextInQueue[position.sheetId]) {
             nextInQueue[position.sheetId] = [];
           }