Skip to content

Commit 0b84fb5

Browse files
committed
[FIX] xlsx: make import verbose
e6ebca3 (probably) mistakenly changed the default `verboseImport` model argument from `true` to `false`. This meant that we no longer got any information in the console about what happened during the import of an XLSX file. closes #7051 Task: 0 X-original-commit: e726d26 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com> Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
1 parent c0f001d commit 0b84fb5

File tree

2 files changed

+22
-10
lines changed

2 files changed

+22
-10
lines changed

src/model.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ export class Model extends EventBus<any> implements CommandDispatcher {
195195
config: Partial<ModelConfig> = {},
196196
stateUpdateMessages: StateUpdateMessage[] = [],
197197
uuidGenerator: UuidGenerator = new UuidGenerator(),
198-
verboseImport = false
198+
verboseImport = true
199199
) {
200200
const start = performance.now();
201201
console.debug("##### Model creation #####");

tests/model/model.test.ts

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -374,10 +374,16 @@ describe("Model", () => {
374374
const transport = new MockTransportService();
375375
const spy = jest.spyOn(transport, "sendMessage");
376376
const xlsxData = await getTextXlsxFiles();
377-
new Model(xlsxData, {
378-
transportService: transport,
379-
client: { id: "test", name: "Test" },
380-
});
377+
new Model(
378+
xlsxData,
379+
{
380+
transportService: transport,
381+
client: { id: "test", name: "Test" },
382+
},
383+
undefined,
384+
undefined,
385+
false
386+
);
381387
expect(spy).toHaveBeenCalledWith({
382388
type: "SNAPSHOT",
383389
version: MESSAGE_VERSION,
@@ -392,11 +398,17 @@ describe("Model", () => {
392398
const transport = new MockTransportService();
393399
transport.onNewMessage("listener", (message) => messages.push(message));
394400
const xlsxData = await getTextXlsxFiles();
395-
new Model(xlsxData, {
396-
transportService: transport,
397-
client: { id: "test", name: "Test" },
398-
mode: "readonly",
399-
});
401+
new Model(
402+
xlsxData,
403+
{
404+
transportService: transport,
405+
client: { id: "test", name: "Test" },
406+
mode: "readonly",
407+
},
408+
undefined,
409+
undefined,
410+
false
411+
);
400412
expect(messages.map((m) => m.type)).not.toContain("SNAPSHOT_CREATED");
401413
});
402414
});

0 commit comments

Comments
 (0)