[FIX] model: ensure chart ID unicity

We have a function `forceUnicityOfFigure` that repair the spreadsheet
data at import to force the figure ID unicity. But since the
introduction of carousels, we also need to ensure the chart ID unicity
(after the migration, chart ID and figure ID are the same).

closes #7356

Task: 5153264
X-original-commit: cb66cfd
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>

Author: hokolomopo

packages/o-spreadsheet-engine/src/migrations/data.ts

@@ -154,13 +154,21 @@ function forceUnicityOfFigure(data: Partial<WorkbookData>): Partial<WorkbookData
     return data;
   }
   const figureIds = new Set();
+  const chartIds = new Set();
   const uuidGenerator = new UuidGenerator();
   for (const sheet of data.sheets || []) {
     for (const figure of sheet.figures || []) {
       if (figureIds.has(figure.id)) {
         figure.id += uuidGenerator.smallUuid();
       }
       figureIds.add(figure.id);
+
+      if (figure.tag === "chart") {
+        if (chartIds.has(figure.data?.chartId)) {
+          figure.data.chartId += uuidGenerator.smallUuid();
+        }
+        chartIds.add(figure.data?.chartId);
+      }
     }
   }
 

tests/figures/chart/chart_plugin.test.ts

@@ -805,6 +805,30 @@ describe("datasource tests", function () {
     expect(cmd3).toBeCancelledBecause(CommandResult.DuplicatedChartId);
   });
 
+  test("Cannot have duplicate chart id at model creation", () => {
+    const figure = { id: "figureId", tag: "chart", width: 400, height: 300, x: 100, y: 100 };
+    const model = new Model({
+      version: 7,
+      sheets: [
+        {
+          id: "sh1",
+          figures: [
+            { ...figure, data: { type: "line", dataSets: [], labelRange: "A1:A2" } },
+            { ...figure, data: { type: "line", dataSets: [], labelRange: "A1:A2" } },
+          ],
+        },
+      ],
+    });
+
+    const figures = model.getters.getFigures("sh1");
+    expect(figures).toHaveLength(2);
+    expect(figures[0].id).not.toEqual(figures[1].id);
+
+    const chartIds = model.getters.getChartIds("sh1");
+    expect(chartIds).toHaveLength(2);
+    expect(chartIds[0]).not.toEqual(chartIds[1]);
+  });
+
   test("reject updates that target a inexistent chart", () => {
     createChart(
       model,