[FIX] menu_items: fix sequence calculation for pivot data sources

Depending on the number of pivot tables, the pivot items could be
displayed after other items (e.g. Re-insert dynamic pivot) in the
topbar menu.

Practically, the number of pivots to observe the issue is not realistic,
as it requires more than 970 pivots.
But the issue can be observed easily with 25 lists in Odoo.

To fix the issue, we need to compute the sequence with decimal numbers,
to ensure that the pivot items are always between the first sequence
(50) and sequence + 1 (51).

closes #7061

Task: 5025230
X-original-commit: 1462cbc
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>

Author: pro-odoo

src/actions/data_actions.ts

@@ -73,7 +73,7 @@ export const splitToColumns: ActionSpec = {
 export const reinsertDynamicPivotMenu: ActionSpec = {
   id: "reinsert_dynamic_pivot",
   name: _t("Re-insert dynamic pivot"),
-  sequence: 1020,
+  sequence: 60,
   icon: "o-spreadsheet-Icon.INSERT_PIVOT",
   children: [ACTIONS.REINSERT_DYNAMIC_PIVOT_CHILDREN],
   isVisible: (env) =>
@@ -83,7 +83,7 @@ export const reinsertDynamicPivotMenu: ActionSpec = {
 export const reinsertStaticPivotMenu: ActionSpec = {
   id: "reinsert_static_pivot",
   name: _t("Re-insert static pivot"),
-  sequence: 1020,
+  sequence: 70,
   icon: "o-spreadsheet-Icon.INSERT_PIVOT",
   children: [ACTIONS.REINSERT_STATIC_PIVOT_CHILDREN],
   isVisible: (env) =>

src/registries/menus/topbar_menu_registry.ts

@@ -468,8 +468,9 @@ topbarMenuRegistry
     sequence: 40,
     separator: true,
   })
-  .addChild("data_sources_data", ["data"], (env) => {
+  .addChild("pivot_data_sources", ["data"], (env) => {
     const sequence = 50;
+    const numberOfPivots = env.model.getters.getPivotIds().length;
     return env.model.getters.getPivotIds().map((pivotId, index) => {
       const highlightProvider = {
         get highlights() {
@@ -479,7 +480,7 @@ topbarMenuRegistry
       return {
         id: `item_pivot_${env.model.getters.getPivotFormulaId(pivotId)}`,
         name: env.model.getters.getPivotDisplayName(pivotId),
-        sequence: sequence + index,
+        sequence: sequence + index / numberOfPivots,
         isReadonlyAllowed: true,
         execute: (env) => env.openSidePanel("PivotSidePanel", { pivotId }),
         isEnabled: (env) => !env.isSmall,