[FIX] data_validation: selecting range from another sheet

Steps to reproduce:
- Create a new sheet (Sheet2).
- On Sheet1, open the Data Validation side panel.
- Add a DV with type "isValueInRange".
- Click on the selection input to select the range.
- Navigate to Sheet2 and select the range.
- Click on Save without confirming the ranges.

Before this commit:
- The DV was created on Sheet2 instead of remaining on Sheet1.

After this commit:
- The DV is correctly created on the original sheet (Sheet1).

closes #7323

Task: 4948201
X-original-commit: be6bf8c
Signed-off-by: Dhrutik Patel (dhrp) <dhrp@odoo.com>
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>

Author: dhrp-odoo

src/components/side_panel/data_validation/dv_editor/dv_editor.ts

@@ -11,6 +11,7 @@ import {
   DataValidationRule,
   DataValidationRuleData,
   SpreadsheetChildEnv,
+  UID,
 } from "../../../../types";
 import { SelectionInput } from "../../../selection_input/selection_input";
 import { DVTerms } from "../../../translations_terms";
@@ -43,14 +44,15 @@ export class DataValidationEditor extends Component<Props, SpreadsheetChildEnv>
   };
 
   state = useState<State>({ rule: this.defaultDataValidationRule, errors: [] });
+  private editingSheetId!: UID;
 
   setup() {
+    this.editingSheetId = this.env.model.getters.getActiveSheetId();
     if (this.props.rule) {
-      const sheetId = this.env.model.getters.getActiveSheetId();
       this.state.rule = {
         ...this.props.rule,
         ranges: this.props.rule.ranges.map((range) =>
-          this.env.model.getters.getRangeString(range, sheetId)
+          this.env.model.getters.getRangeString(range, this.editingSheetId)
         ),
       };
       this.state.rule.criterion.type = this.props.rule.criterion.type;
@@ -92,17 +94,16 @@ export class DataValidationEditor extends Component<Props, SpreadsheetChildEnv>
     const criterion = rule.criterion;
     const criterionEvaluator = dataValidationEvaluatorRegistry.get(criterion.type);
 
-    const sheetId = this.env.model.getters.getActiveSheetId();
     const values = criterion.values
       .slice(0, criterionEvaluator.numberOfValues(criterion))
       .map((value) => value?.trim())
       .filter((value) => value !== "" && value !== undefined)
       .map((value) => canonicalizeContent(value, locale));
     rule.criterion = { ...criterion, values };
     return {
-      sheetId,
+      sheetId: this.editingSheetId,
       ranges: this.state.rule.ranges.map((xc) =>
-        this.env.model.getters.getRangeDataFromXc(sheetId, xc)
+        this.env.model.getters.getRangeDataFromXc(this.editingSheetId, xc)
       ),
       rule,
     };

tests/data_validation/data_validation_generics_side_panel_component.test.ts

@@ -1,7 +1,12 @@
 import { Model } from "../../src";
 import { DataValidationPanel } from "../../src/components/side_panel/data_validation/data_validation_panel";
 import { UID } from "../../src/types";
-import { addDataValidation, updateLocale } from "../test_helpers/commands_helpers";
+import {
+  activateSheet,
+  addDataValidation,
+  createSheet,
+  updateLocale,
+} from "../test_helpers/commands_helpers";
 import { FR_LOCALE } from "../test_helpers/constants";
 import { click, setInputValueAndTrigger, simulateClick } from "../test_helpers/dom_helper";
 import {
@@ -270,6 +275,29 @@ describe("data validation sidePanel component", () => {
     expect(getDataValidationRules(model, sheetId)).toMatchObject([{ id: "id1" }, { id: "id2" }]);
   });
 
+  test("DV stays on original sheet when range is selected from another sheet and saved", async () => {
+    createSheet(model, { sheetId: "sh2" });
+
+    await simulateClick(".o-dv-add");
+    await nextTick();
+    setInputValueAndTrigger(".o-selection-input input", "A1:A5");
+    await changeCriterionType("isValueInRange");
+
+    const rangeInput = fixture.querySelectorAll<HTMLInputElement>(".o-selection-input input")[1];
+    activateSheet(model, "sh2");
+    await setInputValueAndTrigger(rangeInput, "A1:A5");
+    await simulateClick(".o-dv-save");
+
+    expect(getDataValidationRules(model, sheetId)).toEqual([
+      {
+        id: expect.any(String),
+        criterion: { type: "isValueInRange", displayStyle: "arrow", values: ["A1:A5"] },
+        ranges: ["A1:A5"],
+      },
+    ]);
+    expect(getDataValidationRules(model, "sh2")).toHaveLength(0);
+  });
+
   describe("Locale", () => {
     test("Number preview is localized", async () => {
       updateLocale(model, FR_LOCALE);